Re: [Qemu-devel] [PATCH] hw/i386: add device tree support

2016-04-06 Thread Antonio Borneo
On Tue, Apr 5, 2016 at 10:43 PM, Eduardo Habkost wrote: > [...] > > One small comment below: > > [...] >> + >> +load_image(dtb_filename, setup_data->data); > > load_image() is deprecated, please use > load_image_size(dtb_filename, setup_data->data, dtb_size) > instead. Yes, correct! I mis

Re: [Qemu-devel] [PATCH] hw/i386: add device tree support

2016-04-05 Thread Antonio Borneo
On Tue, Apr 5, 2016 at 7:40 PM, Sebastian Andrzej Siewior wrote: > On 04/05/2016 07:11 PM, Antonio Borneo wrote: >> Hi, > Hi, > >> I'm not expert on the x86 memory map at boot and during kernel >> boot; I found easy to just append the dtb to the kernel image. >>>From my tests this patch is working

[Qemu-devel] [PATCH] hw/i386: add device tree support

2016-04-05 Thread Antonio Borneo
With "-dtb" on command-line: - append the device tree blob to the kernel image; - pass the blob's pointer to the kernel through setup_data, as requested by upstream kernel commit da6b737b9ab7 ("x86: Add device tree support"). The device tree blob is passed as-is to the guest; none of its field

Re: [Qemu-devel] [PATCH] hw/i386: add device tree support

2016-04-05 Thread Sebastian Andrzej Siewior
On 04/05/2016 07:11 PM, Antonio Borneo wrote: > Hi, Hi, > I'm not expert on the x86 memory map at boot and during kernel > boot; I found easy to just append the dtb to the kernel image. >>From my tests this patch is working fine. > If you have any hint for a different loading address for dtb, I >

Re: [Qemu-devel] [PATCH] hw/i386: add device tree support

2016-04-05 Thread Eduardo Habkost
On Tue, Apr 05, 2016 at 07:11:28PM +0200, Antonio Borneo wrote: > With "-dtb" on command-line: > - append the device tree blob to the kernel image; > - pass the blob's pointer to the kernel through setup_data, as > requested by upstream kernel commit da6b737b9ab7 ("x86: Add > device tree suppor