On Fri, Feb 09, 2018 at 10:23:13AM +0100, Richard Braun wrote:
> On Thu, Feb 08, 2018 at 02:58:29PM +, Peter Maydell wrote:
> > The guest can clear the TC and TXE bits by writing to the USART_SR
> > directly, so this code should set both of them, I think ?
>
> Right, nice catch.
Although, aft
On Thu, Feb 08, 2018 at 03:33:32PM -0800, Alistair Francis wrote:
> >> @@ -96,12 +96,10 @@ static uint64_t stm32f2xx_usart_read(void *opaque,
> >> hwaddr addr,
> >> switch (addr) {
> >> case USART_SR:
> >> retvalue = s->usart_sr;
> >> -s->usart_sr &= ~USART_SR_TC;
>
> T
On Thu, Feb 08, 2018 at 02:58:29PM +, Peter Maydell wrote:
> On 4 February 2018 at 20:41, Richard Braun wrote:
> > Consider that data is always immediately sent. As a result, keep
> > the SR_TXE and SR_TC bits always set. In addition, fix the reset value
> > of the USART status register.
>
>
On Thu, Feb 8, 2018 at 6:58 AM, Peter Maydell wrote:
> On 4 February 2018 at 20:41, Richard Braun wrote:
>> Consider that data is always immediately sent. As a result, keep
>> the SR_TXE and SR_TC bits always set. In addition, fix the reset value
>> of the USART status register.
>
> Do you know w
On 4 February 2018 at 20:41, Richard Braun wrote:
> Consider that data is always immediately sent. As a result, keep
> the SR_TXE and SR_TC bits always set. In addition, fix the reset value
> of the USART status register.
Do you know what the data sheet means when it says that TC
can be cleared b
Consider that data is always immediately sent. As a result, keep
the SR_TXE and SR_TC bits always set. In addition, fix the reset value
of the USART status register.
Signed-off-by: Richard Braun
---
hw/char/stm32f2xx_usart.c | 4
include/hw/char/stm32f2xx_usart.h | 7 ++-
2 file
