Re: [Qemu-devel] [PATCH] hw/audio/sb16.c: Convert file to new logging API

2018-02-01 Thread Gerd Hoffmann
> > ldebug() should probably trace points. > > I need help with this. I tried replacing ldebug() with > "qemu_log_mask(LOG_TRACE,", but that caused a lot of messages to be > printed to the terminal. It is odd because I thought I had to use "-d > trace" to make it print. Do you have another suggest

Re: [Qemu-devel] [PATCH] hw/audio/sb16.c: Convert file to new logging API

2018-01-31 Thread Programmingkid
> On Jan 31, 2018, at 4:43 PM, Programmingkid wrote: > >> >> On Jan 31, 2018, at 4:22 AM, Gerd Hoffmann wrote: >> >> On Tue, Jan 30, 2018 at 10:30:46AM -0500, Programmingkid wrote: >>> On Jan 30, 2018, at 4:41 AM, Gerd Hoffmann wrote: > @@ -148,15 +142,16 @@ static int irq_of

Re: [Qemu-devel] [PATCH] hw/audio/sb16.c: Convert file to new logging API

2018-01-31 Thread Programmingkid
> On Jan 31, 2018, at 4:22 AM, Gerd Hoffmann wrote: > > On Tue, Jan 30, 2018 at 10:30:46AM -0500, Programmingkid wrote: >> >>> On Jan 30, 2018, at 4:41 AM, Gerd Hoffmann wrote: >>> @@ -148,15 +142,16 @@ static int irq_of_magic (int magic) #if 0 static void log_dsp (SB16State *d

Re: [Qemu-devel] [PATCH] hw/audio/sb16.c: Convert file to new logging API

2018-01-31 Thread Gerd Hoffmann
On Tue, Jan 30, 2018 at 10:30:46AM -0500, Programmingkid wrote: > > > On Jan 30, 2018, at 4:41 AM, Gerd Hoffmann wrote: > > > >> @@ -148,15 +142,16 @@ static int irq_of_magic (int magic) > >> #if 0 > >> static void log_dsp (SB16State *dsp) > >> { > >> -ldebug ("%s:%s:%d:%s:dmasize=%d:freq=%d

Re: [Qemu-devel] [PATCH] hw/audio/sb16.c: Convert file to new logging API

2018-01-30 Thread Programmingkid
> On Jan 30, 2018, at 4:41 AM, Gerd Hoffmann wrote: > >> @@ -148,15 +142,16 @@ static int irq_of_magic (int magic) >> #if 0 >> static void log_dsp (SB16State *dsp) >> { >> -ldebug ("%s:%s:%d:%s:dmasize=%d:freq=%d:const=%d:speaker=%d\n", >> -dsp->fmt_stereo ? "Stereo" : "Mono", >>

Re: [Qemu-devel] [PATCH] hw/audio/sb16.c: Convert file to new logging API

2018-01-30 Thread Gerd Hoffmann
> @@ -148,15 +142,16 @@ static int irq_of_magic (int magic) > #if 0 > static void log_dsp (SB16State *dsp) > { > -ldebug ("%s:%s:%d:%s:dmasize=%d:freq=%d:const=%d:speaker=%d\n", > -dsp->fmt_stereo ? "Stereo" : "Mono", > -dsp->fmt_signed ? "Signed" : "Unsigned", > -

[Qemu-devel] [PATCH] hw/audio/sb16.c: Convert file to new logging API

2018-01-29 Thread John Arbuckle
Use the qemu_log_mask() function to log messages. Signed-off-by: John Arbuckle --- hw/audio/sb16.c | 221 1 file changed, 112 insertions(+), 109 deletions(-) diff --git a/hw/audio/sb16.c b/hw/audio/sb16.c index 6ab2f6f89a..bdb79aeafa 1006