On 4 October 2012 12:50, Evgeny Voevodin wrote:
> On 10/02/2012 07:50 AM, Evgeny Voevodin wrote:
>>
>> s->cpu_enabled is an array, so s->cpu_enabled ? "En" : "Dis" returns
>> "En" always. We should use s->cpu_enabled[cpu] here.
>
> Did anybody pick this up?
Yeah, I've put it in arm-devs.next.
--
On 10/02/2012 07:50 AM, Evgeny Voevodin wrote:
s->cpu_enabled is an array, so s->cpu_enabled ? "En" : "Dis" returns
"En" always. We should use s->cpu_enabled[cpu] here.
Signed-off-by: Evgeny Voevodin
---
hw/arm_gic.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/a
s->cpu_enabled is an array, so s->cpu_enabled ? "En" : "Dis" returns
"En" always. We should use s->cpu_enabled[cpu] here.
Signed-off-by: Evgeny Voevodin
---
hw/arm_gic.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm_gic.c b/hw/arm_gic.c
index 55871fa..4024dae 1006
On 1 October 2012 13:11, Evgeny Voevodin wrote:
> s->cpu_enabled is a massive, so s->cpu_enabled ? "En" : "Dis" returns
"is an array"
> "En" always. We should use s->cpu_enabled[cpu] here.
>
> Signed-off-by: Evgeny Voevodin
...but nice catch.
Reviewed-by: Peter Maydell
-- PMM
s->cpu_enabled is a massive, so s->cpu_enabled ? "En" : "Dis" returns
"En" always. We should use s->cpu_enabled[cpu] here.
Signed-off-by: Evgeny Voevodin
---
hw/arm_gic.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm_gic.c b/hw/arm_gic.c
index 55871fa..4024dae 100
