Re: [Qemu-devel] [PATCH] hw/arm: virt uart fix

2016-06-08 Thread Peter Maydell
On 8 June 2016 at 07:23, Jérôme Forissier wrote: > > > On 06/08/2016 04:30 AM, xiaoqiang zhao wrote: >> commit f0d1d2c115dffc1fbaf954d0b449db05c5eb79b1 >> ("hw/char: QOM'ify pl011 model") break qemu-system-arm virt machine >> if option '-machine secure=on' is provided. >> >> The function create_ua

Re: [Qemu-devel] [PATCH] hw/arm: virt uart fix

2016-06-07 Thread Jérôme Forissier
On 06/08/2016 04:30 AM, xiaoqiang zhao wrote: > commit f0d1d2c115dffc1fbaf954d0b449db05c5eb79b1 > ("hw/char: QOM'ify pl011 model") break qemu-system-arm virt machine > if option '-machine secure=on' is provided. > > The function create_uart is called twice. So make CharDriverState pointer > a pa

[Qemu-devel] [PATCH] hw/arm: virt uart fix

2016-06-07 Thread xiaoqiang zhao
commit f0d1d2c115dffc1fbaf954d0b449db05c5eb79b1 ("hw/char: QOM'ify pl011 model") break qemu-system-arm virt machine if option '-machine secure=on' is provided. The function create_uart is called twice. So make CharDriverState pointer a parameter to create_uart instead of hardcoded. Signed-off-by: