Re: [Qemu-devel] [PATCH] hw/arm/virt: fix psci conduit in acpi when el3 enabled

2018-07-06 Thread Peter Maydell
On 25 June 2018 at 10:56, Hongbo Zhang wrote: > On 25 June 2018 at 17:06, Peter Maydell wrote: >> On 25 June 2018 at 05:06, Hongbo Zhang wrote: >>> Hi Peter, >>> Yes, your considerations reasonable. >>> But in practice of hardware platforms, programmer checks that Arm TF >>> is using SMC for PSC

Re: [Qemu-devel] [PATCH] hw/arm/virt: fix psci conduit in acpi when el3 enabled

2018-06-25 Thread Hongbo Zhang
On 25 June 2018 at 17:06, Peter Maydell wrote: > On 25 June 2018 at 05:06, Hongbo Zhang wrote: >> Hi Peter, >> Yes, your considerations reasonable. >> But in practice of hardware platforms, programmer checks that Arm TF >> is using SMC for PSCI call conduit, then fix it manually in the ACPI >> ta

Re: [Qemu-devel] [PATCH] hw/arm/virt: fix psci conduit in acpi when el3 enabled

2018-06-25 Thread Peter Maydell
On 25 June 2018 at 05:06, Hongbo Zhang wrote: > Hi Peter, > Yes, your considerations reasonable. > But in practice of hardware platforms, programmer checks that Arm TF > is using SMC for PSCI call conduit, then fix it manually in the ACPI > table, reason may be that Arm TF is lack of ACPI support,

Re: [Qemu-devel] [PATCH] hw/arm/virt: fix psci conduit in acpi when el3 enabled

2018-06-24 Thread Hongbo Zhang
Hi Peter, Yes, your considerations reasonable. But in practice of hardware platforms, programmer checks that Arm TF is using SMC for PSCI call conduit, then fix it manually in the ACPI table, reason may be that Arm TF is lack of ACPI support, if device tree used, there should be no such thing becau

Re: [Qemu-devel] [PATCH] hw/arm/virt: fix psci conduit in acpi when el3 enabled

2018-06-22 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1529663827-28854-1-git-send-email-hongbo.zh...@linaro.org Subject: [Qemu-devel] [PATCH] hw/arm/virt: fix psci conduit in acpi when el3 enabled === TEST SCRIPT BEGIN

Re: [Qemu-devel] [PATCH] hw/arm/virt: fix psci conduit in acpi when el3 enabled

2018-06-22 Thread no-reply
] hw/arm/virt: fix psci conduit in acpi when el3 enabled === TEST SCRIPT BEGIN === #!/bin/bash set -e git submodule update --init dtc # Let docker tests dump environment info export SHOW_ENV=1 export J=8 time make docker-test-mingw@fedora === TEST SCRIPT END === Updating

Re: [Qemu-devel] [PATCH] hw/arm/virt: fix psci conduit in acpi when el3 enabled

2018-06-22 Thread Peter Maydell
On 22 June 2018 at 11:37, Hongbo Zhang wrote: > When QEMU_PSCI_CONDUIT_DISABLED is set, it doesn't mean all the PSCI > conduits are totally disabled, it only mean the QEMU built-in PSCI > support is disabled, in such a case, e.g. EL3 is enabled and external > firmware (it is usually Arm Trusted Fi

[Qemu-devel] [PATCH] hw/arm/virt: fix psci conduit in acpi when el3 enabled

2018-06-22 Thread Hongbo Zhang
When QEMU_PSCI_CONDUIT_DISABLED is set, it doesn't mean all the PSCI conduits are totally disabled, it only mean the QEMU built-in PSCI support is disabled, in such a case, e.g. EL3 is enabled and external firmware (it is usually Arm Trusted Firmware) is loaded, SMC should be used for the guest to