Re: [Qemu-devel] [PATCH] hw/arm/virt: Allow zero address for PCI IO space

2015-10-16 Thread Laurent Vivier
On 16/10/2015 11:32, Peter Maydell wrote: > On 16 October 2015 at 09:52, Laurent Vivier wrote: >> I'm going to remove the zero address checking and try to start a qemu >> for each of them to see which ones are broken. > > You need to also make sure there's a PCI card in there > and that the gue

Re: [Qemu-devel] [PATCH] hw/arm/virt: Allow zero address for PCI IO space

2015-10-16 Thread Peter Maydell
On 16 October 2015 at 09:52, Laurent Vivier wrote: > I'm going to remove the zero address checking and try to start a qemu > for each of them to see which ones are broken. You need to also make sure there's a PCI card in there and that the guest maps it with a BAR at address zero (testing both MM

Re: [Qemu-devel] [PATCH] hw/arm/virt: Allow zero address for PCI IO space

2015-10-16 Thread Michael S. Tsirkin
On Fri, Oct 16, 2015 at 10:52:00AM +0200, Laurent Vivier wrote: > > > On 13/10/2015 15:55, Peter Maydell wrote: > > On 13 October 2015 at 14:25, Peter Maydell wrote: > >> On 13 October 2015 at 14:19, Michael S. Tsirkin wrote: > >>> On Tue, Oct 13, 2015 at 02:12:34PM +0100, Peter Maydell wrote:

Re: [Qemu-devel] [PATCH] hw/arm/virt: Allow zero address for PCI IO space

2015-10-16 Thread Laurent Vivier
On 13/10/2015 15:55, Peter Maydell wrote: > On 13 October 2015 at 14:25, Peter Maydell wrote: >> On 13 October 2015 at 14:19, Michael S. Tsirkin wrote: >>> On Tue, Oct 13, 2015 at 02:12:34PM +0100, Peter Maydell wrote: Well, if we're going to go around and fix the machines which don't

Re: [Qemu-devel] [PATCH] hw/arm/virt: Allow zero address for PCI IO space

2015-10-13 Thread Peter Maydell
On 13 October 2015 at 14:25, Peter Maydell wrote: > On 13 October 2015 at 14:19, Michael S. Tsirkin wrote: >> On Tue, Oct 13, 2015 at 02:12:34PM +0100, Peter Maydell wrote: >>> Well, if we're going to go around and fix the machines which >>> don't get things right, I guess. It's a shame the defau

Re: [Qemu-devel] [PATCH] hw/arm/virt: Allow zero address for PCI IO space

2015-10-13 Thread Peter Maydell
On 13 October 2015 at 14:19, Michael S. Tsirkin wrote: > On Tue, Oct 13, 2015 at 02:12:34PM +0100, Peter Maydell wrote: >> Well, if we're going to go around and fix the machines which >> don't get things right, I guess. It's a shame the default for >> the global is "this machine is broken", becaus

Re: [Qemu-devel] [PATCH] hw/arm/virt: Allow zero address for PCI IO space

2015-10-13 Thread Michael S. Tsirkin
On Tue, Oct 13, 2015 at 02:12:34PM +0100, Peter Maydell wrote: > On 13 October 2015 at 14:04, Michael S. Tsirkin wrote: > > On Tue, Oct 13, 2015 at 02:47:33PM +0200, Laurent Vivier wrote: > >> MST asked for a global flag: > >> > >> https://lists.gnu.org/archive/html/qemu-ppc/2015-07/msg00364.html

Re: [Qemu-devel] [PATCH] hw/arm/virt: Allow zero address for PCI IO space

2015-10-13 Thread Peter Maydell
On 13 October 2015 at 14:04, Michael S. Tsirkin wrote: > On Tue, Oct 13, 2015 at 02:47:33PM +0200, Laurent Vivier wrote: >> MST asked for a global flag: >> >> https://lists.gnu.org/archive/html/qemu-ppc/2015-07/msg00364.html >> >> But perhaps the machine is not the good place for this global flag

Re: [Qemu-devel] [PATCH] hw/arm/virt: Allow zero address for PCI IO space

2015-10-13 Thread Michael S. Tsirkin
On Tue, Oct 13, 2015 at 02:47:33PM +0200, Laurent Vivier wrote: > > > On 13/10/2015 14:33, Peter Maydell wrote: > > On 13 October 2015 at 13:48, Alexander Gordeev wrote: > >> On Tue, Oct 13, 2015 at 09:16:34AM +0100, Peter Maydell wrote: > >>> In any case, setting pci_allow_0_address is the righ

Re: [Qemu-devel] [PATCH] hw/arm/virt: Allow zero address for PCI IO space

2015-10-13 Thread Laurent Vivier
On 13/10/2015 14:33, Peter Maydell wrote: > On 13 October 2015 at 13:48, Alexander Gordeev wrote: >> On Tue, Oct 13, 2015 at 09:16:34AM +0100, Peter Maydell wrote: >>> In any case, setting pci_allow_0_address is the right thing, >>> so we can just change the commit message in this patch. >> >> I

Re: [Qemu-devel] [PATCH] hw/arm/virt: Allow zero address for PCI IO space

2015-10-13 Thread Peter Maydell
On 13 October 2015 at 13:48, Alexander Gordeev wrote: > On Tue, Oct 13, 2015 at 09:16:34AM +0100, Peter Maydell wrote: >> In any case, setting pci_allow_0_address is the right thing, >> so we can just change the commit message in this patch. > > I will post v2 with an updated changelog then. > >>

Re: [Qemu-devel] [PATCH] hw/arm/virt: Allow zero address for PCI IO space

2015-10-13 Thread Alexander Gordeev
On Tue, Oct 13, 2015 at 09:16:34AM +0100, Peter Maydell wrote: > On 13 October 2015 at 07:31, Alexander Gordeev wrote: > > On Mon, Oct 12, 2015 at 10:03:03PM +0100, Peter Maydell wrote: > >> On 12 October 2015 at 21:55, Alexander Gordeev wrote: > >> > Currently PCI IO address 0 is not allowed eve

Re: [Qemu-devel] [PATCH] hw/arm/virt: Allow zero address for PCI IO space

2015-10-13 Thread Alexander Gordeev
On Mon, Oct 12, 2015 at 10:03:03PM +0100, Peter Maydell wrote: > On 12 October 2015 at 21:55, Alexander Gordeev wrote: > > Currently PCI IO address 0 is not allowed even though > > the IO space starts from 0. As result, PCI IO is not > > possible to use at all. > > I don't see any reason for us n

[Qemu-devel] [PATCH] hw/arm/virt: Allow zero address for PCI IO space

2015-10-13 Thread Alexander Gordeev
Currently PCI IO address 0 is not allowed even though the IO space starts from 0. As result, PCI IO is not possible to use at all. CC: Peter Maydell CC: Andrew Jones Signed-off-by: Alexander Gordeev --- hw/arm/virt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/virt.c b/hw/arm/vi

Re: [Qemu-devel] [PATCH] hw/arm/virt: Allow zero address for PCI IO space

2015-10-13 Thread Peter Maydell
On 13 October 2015 at 07:31, Alexander Gordeev wrote: > On Mon, Oct 12, 2015 at 10:03:03PM +0100, Peter Maydell wrote: >> On 12 October 2015 at 21:55, Alexander Gordeev wrote: >> > Currently PCI IO address 0 is not allowed even though >> > the IO space starts from 0. As result, PCI IO is not >> >

Re: [Qemu-devel] [PATCH] hw/arm/virt: Allow zero address for PCI IO space

2015-10-12 Thread Peter Maydell
On 12 October 2015 at 21:55, Alexander Gordeev wrote: > Currently PCI IO address 0 is not allowed even though > the IO space starts from 0. As result, PCI IO is not > possible to use at all. I don't see any reason for us not to allow 0 IO addresses, but I'm not sure how your your conclusion follo