Re: [Qemu-devel] [PATCH] hw/9pfs: fix P9_STATS_GEN handling

2013-10-30 Thread Daniel P. Berrange
On Sun, Oct 27, 2013 at 03:41:34AM +0300, Kirill A. Shutemov wrote: > From: "Kirill A. Shutemov" > > Currently we have few issues with P9_STATS_GEN: > > - We don't try to read st_gen anything except files or directories, but >still set P9_STATS_GEN bit in st_result_mask. It may mislead clie

Re: [Qemu-devel] [PATCH] hw/9pfs: fix P9_STATS_GEN handling

2013-10-30 Thread Kirill A. Shutemov
On Sun, Oct 27, 2013 at 03:41:34AM +0300, Kirill A. Shutemov wrote: > From: "Kirill A. Shutemov" > > Currently we have few issues with P9_STATS_GEN: > > - We don't try to read st_gen anything except files or directories, but >still set P9_STATS_GEN bit in st_result_mask. It may mislead clie

[Qemu-devel] [PATCH] hw/9pfs: fix P9_STATS_GEN handling

2013-10-26 Thread Kirill A. Shutemov
From: "Kirill A. Shutemov" Currently we have few issues with P9_STATS_GEN: - We don't try to read st_gen anything except files or directories, but still set P9_STATS_GEN bit in st_result_mask. It may mislead client: we present garbage as valid st_gen. - If we failed to get valid st_gen

[Qemu-devel] [PATCH] hw/9pfs: fix P9_STATS_GEN handling

2013-10-26 Thread Kirill A. Shutemov
Currently we have few issues with P9_STATS_GEN: - We don't try to read st_gen anything except files or directories, but still set P9_STATS_GEN bit in st_result_mask. It may mislead client: we present garbage as valid st_gen. - If we failed to get valid st_gen with ENOTTY, we ignore error,