Re: [Qemu-devel] [PATCH] hvf: Add missing break statement

2019-04-26 Thread Paolo Bonzini
On 22/04/19 18:09, Philippe Mathieu-Daudé wrote: > Oops... I'm surprised no compiler warned about this yet... > > This probably mean: > - This code is not covered by Continuous Integration > - Upstream maintainers are not building this code > - Upstream is not running this code > > Please tell me

Re: [Qemu-devel] [PATCH] hvf: Add missing break statement

2019-04-22 Thread Philippe Mathieu-Daudé
On 4/22/19 5:42 AM, Chen Zhang via Qemu-devel wrote: > In target/i386/hvf/hvf.c, a break statement was probably missing in > `hvf_vcpu_exec()`, in handling EXIT_REASON_HLT. > > These lines seemed to be equivalent to `kvm_handle_halt()`. > Fixes: c97d6d2cdf97 > Signed-off-by: Chen Zhang > ---

Re: [Qemu-devel] [PATCH] hvf: Add missing break statement

2019-04-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/087f1d9c-109d-41d1-be2c-ce5d840c9...@me.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 087f1d9c-109d-41d1-be2c-ce5d840c9...@me.com Subject: [Qemu-devel] [PATCH] hvf: Add

[Qemu-devel] [PATCH] hvf: Add missing break statement

2019-04-21 Thread Chen Zhang via Qemu-devel
In target/i386/hvf/hvf.c, a break statement was probably missing in `hvf_vcpu_exec()`, in handling EXIT_REASON_HLT. These lines seemed to be equivalent to `kvm_handle_halt()`. Signed-off-by: Chen Zhang --- target/i386/hvf/hvf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/i386/hv