Re: [Qemu-devel] [PATCH] hostmem-memfd: honour share=on/off property

2018-11-26 Thread Paolo Bonzini
On 28/08/18 17:38, Marc-André Lureau wrote: > The share=on/off property is used to modified mmap() MAP_SHARED > setting. Make it on by default for convenience and compatibility > reasons. > > Signed-off-by: Marc-André Lureau Is this still needed? Paolo > --- > backends/hostmem-memfd.c | 4 +++

Re: [Qemu-devel] [PATCH] hostmem-memfd: honour share=on/off property

2018-08-30 Thread Marc-André Lureau
Hi On Thu, Aug 30, 2018 at 10:20 AM Igor Mammedov wrote: > > On Wed, 29 Aug 2018 14:36:00 +0200 > Marc-André Lureau wrote: > > > Hi > > > > On Wed, Aug 29, 2018 at 10:50 AM Igor Mammedov wrote: > > > > > > On Tue, 28 Aug 2018 18:55:35 +0200 > > > Marc-André Lureau wrote: > > > > > > > On Tue,

Re: [Qemu-devel] [PATCH] hostmem-memfd: honour share=on/off property

2018-08-30 Thread Igor Mammedov
On Tue, 28 Aug 2018 17:38:40 +0200 Marc-André Lureau wrote: > The share=on/off property is used to modified mmap() MAP_SHARED > setting. Make it on by default for convenience and compatibility > reasons. > > Signed-off-by: Marc-André Lureau > --- > backends/hostmem-memfd.c | 4 +++- > qemu-opt

Re: [Qemu-devel] [PATCH] hostmem-memfd: honour share=on/off property

2018-08-30 Thread Igor Mammedov
On Wed, 29 Aug 2018 14:36:00 +0200 Marc-André Lureau wrote: > Hi > > On Wed, Aug 29, 2018 at 10:50 AM Igor Mammedov wrote: > > > > On Tue, 28 Aug 2018 18:55:35 +0200 > > Marc-André Lureau wrote: > > > > > On Tue, Aug 28, 2018 at 6:54 PM Marc-André Lureau > > > wrote: > > > > > > > > Hi >

Re: [Qemu-devel] [PATCH] hostmem-memfd: honour share=on/off property

2018-08-29 Thread Marc-André Lureau
Hi On Wed, Aug 29, 2018 at 10:50 AM Igor Mammedov wrote: > > On Tue, 28 Aug 2018 18:55:35 +0200 > Marc-André Lureau wrote: > > > On Tue, Aug 28, 2018 at 6:54 PM Marc-André Lureau > > wrote: > > > > > > Hi > > > > > > On Tue, Aug 28, 2018 at 6:49 PM Igor Mammedov wrote: > > > > > > > > On Tue,

Re: [Qemu-devel] [PATCH] hostmem-memfd: honour share=on/off property

2018-08-29 Thread Igor Mammedov
On Tue, 28 Aug 2018 18:55:35 +0200 Marc-André Lureau wrote: > On Tue, Aug 28, 2018 at 6:54 PM Marc-André Lureau > wrote: > > > > Hi > > > > On Tue, Aug 28, 2018 at 6:49 PM Igor Mammedov wrote: > > > > > > On Tue, 28 Aug 2018 17:38:40 +0200 > > > Marc-André Lureau wrote: > > > > > > > The s

Re: [Qemu-devel] [PATCH] hostmem-memfd: honour share=on/off property

2018-08-28 Thread Marc-André Lureau
On Tue, Aug 28, 2018 at 6:54 PM Marc-André Lureau wrote: > > Hi > > On Tue, Aug 28, 2018 at 6:49 PM Igor Mammedov wrote: > > > > On Tue, 28 Aug 2018 17:38:40 +0200 > > Marc-André Lureau wrote: > > > > > The share=on/off property is used to modified mmap() MAP_SHARED > > > setting. Make it on by

Re: [Qemu-devel] [PATCH] hostmem-memfd: honour share=on/off property

2018-08-28 Thread Marc-André Lureau
Hi On Tue, Aug 28, 2018 at 6:49 PM Igor Mammedov wrote: > > On Tue, 28 Aug 2018 17:38:40 +0200 > Marc-André Lureau wrote: > > > The share=on/off property is used to modified mmap() MAP_SHARED > > setting. Make it on by default for convenience and compatibility > > reasons. > it would be nice to

Re: [Qemu-devel] [PATCH] hostmem-memfd: honour share=on/off property

2018-08-28 Thread Igor Mammedov
On Tue, 28 Aug 2018 17:38:40 +0200 Marc-André Lureau wrote: > The share=on/off property is used to modified mmap() MAP_SHARED > setting. Make it on by default for convenience and compatibility > reasons. it would be nice to state reasons here. also flipping default to on is behavioral change whe

[Qemu-devel] [PATCH] hostmem-memfd: honour share=on/off property

2018-08-28 Thread Marc-André Lureau
The share=on/off property is used to modified mmap() MAP_SHARED setting. Make it on by default for convenience and compatibility reasons. Signed-off-by: Marc-André Lureau --- backends/hostmem-memfd.c | 4 +++- qemu-options.hx | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) d