Re: [Qemu-devel] [PATCH] hmp: fix block_set_io_throttle

2017-02-21 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > Commit 7a9877a made the 'device' parameter to BlockIOThrottle > optional, favoring 'id' instead. But it forgot to update the > HMP usage to set has_device, which makes all attempts to change > throttling via HMP fail with "Need exactly one of 'device' and

Re: [Qemu-devel] [PATCH] hmp: fix block_set_io_throttle

2017-01-23 Thread Stefan Hajnoczi
On Fri, Jan 20, 2017 at 05:03:59PM -0600, Eric Blake wrote: > Commit 7a9877a made the 'device' parameter to BlockIOThrottle > optional, favoring 'id' instead. But it forgot to update the > HMP usage to set has_device, which makes all attempts to change > throttling via HMP fail with "Need exactly

[Qemu-devel] [PATCH] hmp: fix block_set_io_throttle

2017-01-20 Thread Eric Blake
Commit 7a9877a made the 'device' parameter to BlockIOThrottle optional, favoring 'id' instead. But it forgot to update the HMP usage to set has_device, which makes all attempts to change throttling via HMP fail with "Need exactly one of 'device' and 'id'" CC: qemu-sta...@nongnu.org Signed-off-by: