Re: [Qemu-devel] [PATCH] hid: vmstat fix

2011-09-18 Thread TeLeMan
On Thu, Sep 15, 2011 at 21:40, Gerd Hoffmann wrote: > On 09/14/11 09:59, Paolo Bonzini wrote: >> >> On 09/14/2011 09:40 AM, TeLeMan wrote: > > >> > >> The commit "usb/hid: add hid_pointer_activate, use it" used > >> HIDMouseState.mouse_grabbed in hid_pointer_activate(), so > >>

Re: [Qemu-devel] [PATCH] hid: vmstat fix

2011-09-15 Thread Gerd Hoffmann
On 09/14/11 09:59, Paolo Bonzini wrote: On 09/14/2011 09:40 AM, TeLeMan wrote: >> >> The commit "usb/hid: add hid_pointer_activate, use it" used >> HIDMouseState.mouse_grabbed in hid_pointer_activate(), so >> mouse_grabbed should be added into vmstat. > > Does this fix a bug? qemu_activate_mous

Re: [Qemu-devel] [PATCH] hid: vmstat fix

2011-09-14 Thread Paolo Bonzini
On 09/14/2011 09:40 AM, TeLeMan wrote: >> >> The commit "usb/hid: add hid_pointer_activate, use it" used >> HIDMouseState.mouse_grabbed in hid_pointer_activate(), so >> mouse_grabbed should be added into vmstat. > > Does this fix a bug? qemu_activate_mouse_event_handler is meant to be > ca

Re: [Qemu-devel] [PATCH] hid: vmstat fix

2011-09-14 Thread TeLeMan
On Wed, Sep 14, 2011 at 15:15, Paolo Bonzini wrote: > On 09/14/2011 05:03 AM, TeLeMan wrote: >> >> The commit "usb/hid: add hid_pointer_activate, use it" used >> HIDMouseState.mouse_grabbed in hid_pointer_activate(), so >> mouse_grabbed should be added into vmstat. > > Does this fix a bug?  qemu_a

Re: [Qemu-devel] [PATCH] hid: vmstat fix

2011-09-14 Thread Paolo Bonzini
On 09/14/2011 05:03 AM, TeLeMan wrote: The commit "usb/hid: add hid_pointer_activate, use it" used HIDMouseState.mouse_grabbed in hid_pointer_activate(), so mouse_grabbed should be added into vmstat. Does this fix a bug? qemu_activate_mouse_event_handler is meant to be called once per executi

[Qemu-devel] [PATCH] hid: vmstat fix

2011-09-13 Thread TeLeMan
The commit "usb/hid: add hid_pointer_activate, use it" used HIDMouseState.mouse_grabbed in hid_pointer_activate(), so mouse_grabbed should be added into vmstat. Signed-off-by: TeLeMan --- hw/hid.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/hid.c b/hw/hid.c inde