Re: [Qemu-devel] [PATCH] gtk: cleanup backend dependencies

2014-06-02 Thread Richard Henderson
On 06/02/2014 04:50 AM, Gerd Hoffmann wrote: > @@ -1996,6 +1997,9 @@ if test "$gtk" != "no"; then > gtk_libs=`$pkg_config --libs $gtkpackage` > libs_softmmu="$gtk_libs $libs_softmmu" > gtk="yes" > +if $pkg_config --exists "$gtkx11package >= $gtkversion"; then > +

Re: [Qemu-devel] [PATCH] gtk: cleanup backend dependencies

2014-06-02 Thread Daniel P. Berrange
On Mon, Jun 02, 2014 at 01:50:25PM +0200, Gerd Hoffmann wrote: > Make configure detect gtk x11 backend and link libX11 then. Make > gtk backend specific code properly #ifdef'ed on the GTK_WINDOWING_* > backends at runtime). Our gtk ui code should build and run fine on > any platform now. > > Thi

[Qemu-devel] [PATCH] gtk: cleanup backend dependencies

2014-06-02 Thread Gerd Hoffmann
Make configure detect gtk x11 backend and link libX11 then. Make gtk backend specific code properly #ifdef'ed on the GTK_WINDOWING_* backends at runtime). Our gtk ui code should build and run fine on any platform now. This also fixes the linker failute due to the new XkbGetKeyboard call added by

Re: [Qemu-devel] [PATCH] gtk: cleanup backend dependencies

2014-06-02 Thread Daniel P. Berrange
On Mon, Jun 02, 2014 at 12:10:44PM +0100, Daniel P. Berrange wrote: > On Mon, Jun 02, 2014 at 12:58:33PM +0200, Gerd Hoffmann wrote: > > diff --git a/configure b/configure > > index 0e516f9..b02f822 100755 > > --- a/configure > > +++ b/configure > > @@ -1986,6 +1986,8 @@ fi > > > > if test "$gtk

Re: [Qemu-devel] [PATCH] gtk: cleanup backend dependencies

2014-06-02 Thread Daniel P. Berrange
On Mon, Jun 02, 2014 at 12:58:33PM +0200, Gerd Hoffmann wrote: > diff --git a/configure b/configure > index 0e516f9..b02f822 100755 > --- a/configure > +++ b/configure > @@ -1986,6 +1986,8 @@ fi > > if test "$gtk" != "no"; then > gtkpackage="gtk+-$gtkabi" > +gtkx11package="gtk+-x11-$gtk

[Qemu-devel] [PATCH] gtk: cleanup backend dependencies

2014-06-02 Thread Gerd Hoffmann
Make configure detect gtk x11 and win32 backends. Make gtk backend specific code properly #ifdefed on the new CONFIG_GTK_{X11,WIN32} config options. Our gtk ui code should build fine on any platform now. This also fixes the linker failute due to the new XkbGetKeyboard call added by commit 3158a3