Re: [Qemu-devel] [PATCH] gluster: Abort on AIO completion failure

2013-08-27 Thread Bharata B Rao
On Tue, Aug 27, 2013 at 08:58:05AM +0200, Paolo Bonzini wrote: > > diff --git a/block/gluster.c b/block/gluster.c > > index 46f36f8..942154a 100644 > > --- a/block/gluster.c > > +++ b/block/gluster.c > > @@ -427,20 +427,9 @@ static void gluster_finish_aiocb(struct glfs_fd *fd, > > ssize_t ret, voi

Re: [Qemu-devel] [PATCH] gluster: Abort on AIO completion failure

2013-08-26 Thread Paolo Bonzini
Il 27/08/2013 07:53, Bharata B Rao ha scritto: > Currently if gluster AIO callback thread fails to notify the QEMU thread about > AIO completion, we try graceful recovery by marking the disk drive as > inaccessible. This error recovery code is race-prone as found by Asias and > Stefan. However as f

[Qemu-devel] [PATCH] gluster: Abort on AIO completion failure

2013-08-26 Thread Bharata B Rao
Currently if gluster AIO callback thread fails to notify the QEMU thread about AIO completion, we try graceful recovery by marking the disk drive as inaccessible. This error recovery code is race-prone as found by Asias and Stefan. However as found out by Paolo, this kind of error is impossible and