Re: [Qemu-devel] [PATCH] fpu/softfloat.c: Remove pointless shift of always-zero value

2012-10-01 Thread Aurelien Jarno
On Mon, Sep 24, 2012 at 05:28:35PM +0100, Peter Maydell wrote: > In float16_to_float32, when returning an infinity, just pass zero > as the mantissa argument to packFloat32(), rather than shifting > a value which we know must be zero. > > Signed-off-by: Peter Maydell > --- > Spotted by the clang

Re: [Qemu-devel] [PATCH] fpu/softfloat.c: Remove pointless shift of always-zero value

2012-09-24 Thread Aurelien Jarno
On Mon, Sep 24, 2012 at 05:28:35PM +0100, Peter Maydell wrote: > In float16_to_float32, when returning an infinity, just pass zero > as the mantissa argument to packFloat32(), rather than shifting > a value which we know must be zero. > > Signed-off-by: Peter Maydell > --- > Spotted by the clang

Re: [Qemu-devel] [PATCH] fpu/softfloat.c: Remove pointless shift of always-zero value

2012-09-24 Thread Richard Henderson
On 2012-09-24 09:28, Peter Maydell wrote: > In float16_to_float32, when returning an infinity, just pass zero > as the mantissa argument to packFloat32(), rather than shifting > a value which we know must be zero. > > Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson r~

[Qemu-devel] [PATCH] fpu/softfloat.c: Remove pointless shift of always-zero value

2012-09-24 Thread Peter Maydell
In float16_to_float32, when returning an infinity, just pass zero as the mantissa argument to packFloat32(), rather than shifting a value which we know must be zero. Signed-off-by: Peter Maydell --- Spotted by the clang static analyzer. This brings this code into line with the other float-to-floa