Re: [Qemu-devel] [PATCH] fixup! virtio: introduce virtio_map

2015-10-28 Thread Stefan Hajnoczi
On Tue, Oct 27, 2015 at 11:00:36PM +0200, Michael S. Tsirkin wrote: > Stefan noticed that we must use memmove, not memcpy, > as arguments overlap. > > Signed-off-by: Michael S. Tsirkin > --- > hw/virtio/virtio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Stefan Haj

[Qemu-devel] [PATCH] fixup! virtio: introduce virtio_map

2015-10-27 Thread Michael S. Tsirkin
Stefan noticed that we must use memmove, not memcpy, as arguments overlap. Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index ed1f274..939f802 100644 --- a/hw/virtio/virtio

Re: [Qemu-devel] [PATCH] fixup! virtio: introduce virtio_map

2015-10-27 Thread Cornelia Huck
On Tue, 27 Oct 2015 14:30:05 +0200 "Michael S. Tsirkin" wrote: > --- > > This will fix the issue reported by Cornelia. > > hw/virtio/virtio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c > index be32145..ed1f274 100644 > ---

[Qemu-devel] [PATCH] fixup! virtio: introduce virtio_map

2015-10-27 Thread Michael S. Tsirkin
--- This will fix the issue reported by Cornelia. hw/virtio/virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index be32145..ed1f274 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -449,7 +449,7 @@ int virtqueue_avail