Patchew URL: https://patchew.org/QEMU/20190628183321.ge1...@habkost.net/
Hi,
This series failed build test on s390x host. Please find the details below.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
# HEAD pointing to a commit that has the p
On Sun, May 19, 2019 at 04:54:24AM +0800, Like Xu wrote:
> The global smp variables in s390x are replaced with smp machine properties.
>
> A local variable of the same name would be introduced in the declaration
> phase if it's used widely in the context OR replace it on the spot if it's
> only us
On Fri, 28 Jun 2019 09:15:03 PDT (-0700), Alistair Francis wrote:
---
roms/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/roms/Makefile b/roms/Makefile
index 562ed726fd..dc70fb5aea 100644
--- a/roms/Makefile
+++ b/roms/Makefile
@@ -179,7 +179,7 @@ opensbi64-virt:
---
roms/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/roms/Makefile b/roms/Makefile
index 562ed726fd..dc70fb5aea 100644
--- a/roms/Makefile
+++ b/roms/Makefile
@@ -179,7 +179,7 @@ opensbi64-virt:
PLATFORM="qemu/virt"
cp opensbi/build/platform
On 23/04/2019 13.08, Eduardo Habkost wrote:
> On Tue, Apr 23, 2019 at 07:07:06AM +0200, Thomas Huth wrote:
>> On 22/04/2019 23.04, Eduardo Habkost wrote:
>>> QTest has two parts: the server (-qtest) and the accelerator
>>> (-machine accel=qtest). The accelerator depends on CONFIG_POSIX
>>> due to
On Tue, Apr 23, 2019 at 07:07:06AM +0200, Thomas Huth wrote:
> On 22/04/2019 23.04, Eduardo Habkost wrote:
> > QTest has two parts: the server (-qtest) and the accelerator
> > (-machine accel=qtest). The accelerator depends on CONFIG_POSIX
> > due to its usage of sigwait(), but the server doesn't.
---
ui/spice-app.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ui/spice-app.c b/ui/spice-app.c
index 4f5229f3ee..925b27b708 100644
--- a/ui/spice-app.c
+++ b/ui/spice-app.c
@@ -181,6 +181,8 @@ static void spice_app_display_init(DisplayState *ds,
DisplayOptions *opts)
g_app_info_lau
On Wed, Feb 20, 2019 at 04:47:01PM +0100, Paolo Bonzini wrote:
> Fix a hang that is only latent until qgraph is merged.
>
> Signed-off-by: Paolo Bonzini
I squashed this in, thanks!
> ---
> tests/vhost-user-test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tes
Fix a hang that is only latent until qgraph is merged.
Signed-off-by: Paolo Bonzini
---
tests/vhost-user-test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
index 33030e0..527d3b3 100644
--- a/tests/vhost-user-test.c
++
On Mon, Feb 4, 2019 at 5:56 AM Michael S. Tsirkin wrote:
>
> This update switched structures from __u64 to uint64_t.
> Accordingly, need to print with PRIx64.
>
> Signed-off-by: Michael S. Tsirkin
Reviewed-by: Marc-André Lureau
> ---
> contrib/libvhost-user/libvhost-user.c | 8
> 1 f
Patchew URL: https://patchew.org/QEMU/20190204045543.21238-1-...@redhat.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bi
This update switched structures from __u64 to uint64_t.
Accordingly, need to print with PRIx64.
Signed-off-by: Michael S. Tsirkin
---
contrib/libvhost-user/libvhost-user.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/contrib/libvhost-user/libvhost-user.c
b/contrib
On 12/13/18 9:18 PM, Richard Henderson wrote:
> I didn't get this fix pushed back into the patch set that I actually
> sent last week. The patch is in target-arm.next, and I'm sure you
> would have eventually seen the error in testing.
>
>
> r~
> ---
> target/arm/kvm64.c | 4 ++--
> 1 file chan
I didn't get this fix pushed back into the patch set that I actually
sent last week. The patch is in target-arm.next, and I'm sure you
would have eventually seen the error in testing.
r~
---
target/arm/kvm64.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/arm/kv
On 30/06/2018 18:50, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> This was in e9dd993d-875f-4173-f68e-e6b4e75e3...@amsat.org but I can't
> find it on the list...
>
> tests/test-cutils.c| 2 +-
> tests/test-qemu-opts.c | 2 +-
> 2 files changed, 2 insertions(+
On 30/06/2018 18:50, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> This was in e9dd993d-875f-4173-f68e-e6b4e75e3...@amsat.org but I can't
> find it on the list...
>
> tests/test-cutils.c| 2 +-
> tests/test-qemu-opts.c | 2 +-
> 2 files changed, 2 insertions(+
Signed-off-by: Philippe Mathieu-Daudé
---
This was in e9dd993d-875f-4173-f68e-e6b4e75e3...@amsat.org but I can't
find it on the list...
tests/test-cutils.c| 2 +-
tests/test-qemu-opts.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/test-cutils.c b/tests/test-cu
On Fri, Jun 08, 2018 at 10:37:45AM -0300, Eduardo Habkost wrote:
> On Fri, Jun 08, 2018 at 09:29:43AM -0300, Eduardo Habkost wrote:
> > Change all Python code to use print as a function.
> >
> > This is necessary for Python 3 compatibility.
> >
> > Done using:
> >
> > $ py=$( (g grep -l -E '^#
On Fri, Jun 08, 2018 at 09:29:43AM -0300, Eduardo Habkost wrote:
> Change all Python code to use print as a function.
>
> This is necessary for Python 3 compatibility.
>
> Done using:
>
> $ py=$( (g grep -l -E '^#!.*python';find -name '*.py' -printf '%P\n';) | \
> sort -u | grep -v README.
Fix building issues for targets other than x86_64
Signed-off-by: Viktor Prutyanov
---
Makefile.target | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Makefile.target b/Makefile.target
index 6ae2609..5be6d18 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -138,7 +138,9 @@ obj-y += hw/
On Wed, Feb 07, 2018 at 11:40:25AM +0100, Igor Mammedov wrote:
> it will be used for providing to cpu name resolving class for
> parsing cpu model for system and user emulation code.
>
> Along with change add target to null-machine tests, so
> that when switch to CPU_RESOLVING_TYPE happens,
> it w
On Tue, Jan 09, 2018 at 01:45:13PM -0200, Eduardo Habkost wrote:
> It is valid to have a 48-character model ID on CPUID, however the
> definition of X86CPUDefinition::model_id is char[48], which can
> make the compiler drop the null terminator from the string.
>
> If a CPU model happens to have 48
On Thu, Oct 12, 2017 at 05:45:14PM +0200, Igor Mammedov wrote:
> follow up commit that registers host-spapr-cpu-core type unconditionally
> "ppc: spapr: register 'host' core type along with the rest of core types"
>
> makes 'non' machine crash
> ppc64-softmmu/qemu-system-ppc64 -M none -device h
follow up commit that registers host-spapr-cpu-core type unconditionally
"ppc: spapr: register 'host' core type along with the rest of core types"
makes 'non' machine crash
ppc64-softmmu/qemu-system-ppc64 -M none -device host-spapr-cpu-core
ERROR:qom/object.c:217:object_type_get_instance_size:
On Thu, Sep 28, 2017 at 11:33:57AM +0200, Lukáš Doktor wrote:
> Dne 27.9.2017 v 15:44 Eduardo Habkost napsal(a):
> > On Wed, Sep 27, 2017 at 09:33:21PM +0800, Fam Zheng wrote:
> >> On Wed, 09/27 10:03, Eduardo Habkost wrote:
> >>> @@ -51,7 +54,6 @@ class QEMUMonitorProtocol(object):
> >>>
Dne 27.9.2017 v 15:44 Eduardo Habkost napsal(a):
> On Wed, Sep 27, 2017 at 09:33:21PM +0800, Fam Zheng wrote:
>> On Wed, 09/27 10:03, Eduardo Habkost wrote:
>>> @@ -51,7 +54,6 @@ class QEMUMonitorProtocol(object):
>>> """
>>> self.__events = []
>>> self.__address = addres
On Wed, Sep 27, 2017 at 09:33:21PM +0800, Fam Zheng wrote:
> On Wed, 09/27 10:03, Eduardo Habkost wrote:
> > @@ -51,7 +54,6 @@ class QEMUMonitorProtocol(object):
> > """
> > self.__events = []
> > self.__address = address
> > -self._debug = debug
>
> Should you a
Signed-off-by: Philippe Mathieu-Daudé
---
Based-on: 1505318697-77161-6-git-send-email-imamm...@redhat.com
include/hw/arm/armv7m.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/arm/armv7m.h b/include/hw/arm/armv7m.h
index 68cb30d611..9ad316c76e 100644
--- a/includ
On Tue, Aug 29, 2017 at 06:36:57PM -0300, Eduardo Habkost wrote:
> On Tue, Aug 29, 2017 at 10:12:58AM -0300, Eduardo Habkost wrote:
> > On Tue, Aug 29, 2017 at 12:13:45PM +0100, Daniel P. Berrange wrote:
> > > On Thu, Aug 24, 2017 at 04:23:15PM -0300, Eduardo Habkost wrote:
> [...]
> > > > @@ -4172
On Tue, Aug 29, 2017 at 10:12:58AM -0300, Eduardo Habkost wrote:
> On Tue, Aug 29, 2017 at 12:13:45PM +0100, Daniel P. Berrange wrote:
> > On Thu, Aug 24, 2017 at 04:23:15PM -0300, Eduardo Habkost wrote:
[...]
> > > @@ -4172,6 +4172,9 @@ the path to either a shared memory or huge page
> > > filesy
On Mon, 10 Jul 2017 12:33:31 -0300
Eduardo Habkost wrote:
> On Mon, Jul 10, 2017 at 11:45:57AM -0300, Eduardo Habkost wrote:
> > On Mon, Jul 10, 2017 at 10:10:41AM +0200, Igor Mammedov wrote:
> > > On Fri, 7 Jul 2017 18:30:51 -0300
> > > Eduardo Habkost wrote:
> [...]
> > > > +
> > > > +
On Mon, Jul 10, 2017 at 11:45:57AM -0300, Eduardo Habkost wrote:
> On Mon, Jul 10, 2017 at 10:10:41AM +0200, Igor Mammedov wrote:
> > On Fri, 7 Jul 2017 18:30:51 -0300
> > Eduardo Habkost wrote:
[...]
> > > +
> > > +object_unparent(obj1);
> > > +object_unparent(obj2a);
> > > +object_u
07.07.2017 22:09, Eric Blake wrote:
From: Vladimir Sementsov-Ogievskiy
[eblake minor tweaks to a couple of traces]
Signed-off-by: Eric Blake
---
If you are okay with this, I plan to squash this into your patch 10
when I send my pull request
Ok.
nbd/client.c | 3 +--
nbd/server.c
From: Vladimir Sementsov-Ogievskiy
[eblake minor tweaks to a couple of traces]
Signed-off-by: Eric Blake
---
If you are okay with this, I plan to squash this into your patch 10
when I send my pull request
nbd/client.c | 3 +--
nbd/server.c | 5 +++--
nbd/trace-events | 4 +---
3 files
On Thu, Jun 29, 2017 at 16:28:28 -0400, Emilio G. Cota wrote:
> XXX: After allowing tb_gen_code to run in parallel (see next patch),
> crashes due to races in TCG code are found very quickly with -smp > 1
> (e.g. "tcg/tcg.c:233: tcg_out_label: Assertion `!l->has_value' failed.")
> No
Alex Bennée writes:
> ---
> target/hppa/translate.c | 5 ++---
> target/nios2/translate.c| 5 ++---
> target/openrisc/translate.c | 3 +--
> 3 files changed, 5 insertions(+), 8 deletions(-)
I rebased the patches and forgot to test the compilation of other
architectures. Sorry about that.
---
target/hppa/translate.c | 5 ++---
target/nios2/translate.c| 5 ++---
target/openrisc/translate.c | 3 +--
3 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/target/hppa/translate.c b/target/hppa/translate.c
index e10abc5e04..900870cd5a 100644
--- a/target/hppa/translate.c
On Fri, 5 May 2017 17:36:20 -0300
Eduardo Habkost wrote:
> Fixup will be included in v3, or can be applied by maintainer:
>
> Signed-off-by: Eduardo Habkost
> ---
> hw/core/sysbus.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/core/sysbus.c b/hw/core/sys
On Fri, May 05, 2017 at 01:54:19PM -0300, Eduardo Habkost wrote:
> On Fri, May 05, 2017 at 09:36:22AM +0200, Cornelia Huck wrote:
> [...]
> > > diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c
> > > index c0f560b289..6a2eec8dd0 100644
> > > --- a/hw/core/sysbus.c
> > > +++ b/hw/core/sysbus.c
> > >
On Tue, May 02, 2017 at 05:31:15PM -0300, Eduardo Habkost wrote:
> Introduce a new CPUFeatureSetting QAPI data type, and use it to support
> feature=force on -cpu.
>
> Signed-off-by: Eduardo Habkost
I will include this in v2 to fix the coding style issues.
Signed-off-by: Eduardo Habkost
---
t
On 2017年03月21日 09:39, Peter Xu wrote:
On Mon, Mar 20, 2017 at 08:21:44PM -0500, Eric Blake wrote:
On 03/20/2017 08:12 PM, Michael S. Tsirkin wrote:
Since this patchset depends on vtd vfio series and fixes its breakage
to vhost, I'll pick them up for consistency for next post of vtd vfio
seri
On 03/22/2017 12:35 PM, no-re...@patchew.org wrote:
> Hi,
>
> This series failed build test on s390x host. Please find the details below.
>
> Type: series
> Subject: [Qemu-devel] [PATCH] fixup! qom: Avoid unvisited 'id'/'qom-type' in
> user_creatable_ad
Hi,
This series failed build test on s390x host. Please find the details below.
Type: series
Subject: [Qemu-devel] [PATCH] fixup! qom: Avoid unvisited 'id'/'qom-type' in
user_creatable_add_opts
Message-id: 20170322173023.22654-1-ebl...@redhat.com
=== TEST SCRIPT BEGIN ===
#
CC: qemu-sta...@nongnu.org
Signed-off-by: Eric Blake
---
Markus already issued the pull request, so if that goes in before
he can squash this for a v2, then I'll have to turn this into a
full-blown patch.
v3.5: avoid memory leak when id is not present
v3: enhance commit message
v2: new patch
--
On Mon, Mar 20, 2017 at 08:21:44PM -0500, Eric Blake wrote:
> On 03/20/2017 08:12 PM, Michael S. Tsirkin wrote:
>
> >>
> >> Since this patchset depends on vtd vfio series and fixes its breakage
> >> to vhost, I'll pick them up for consistency for next post of vtd vfio
> >> series as well.
> >>
> >
On 03/20/2017 08:12 PM, Michael S. Tsirkin wrote:
>>
>> Since this patchset depends on vtd vfio series and fixes its breakage
>> to vhost, I'll pick them up for consistency for next post of vtd vfio
>> series as well.
>>
>> Thanks,
>>
>> -- peterx
>
> Sounds good. It's best to order patches in a
On Mon, Mar 20, 2017 at 05:07:34PM +0800, Peter Xu wrote:
> On Mon, Mar 20, 2017 at 11:36:39AM +0800, Jason Wang wrote:
> > We assumes the iommu_ops were attached to the root region of address
> > space. This may not true for all kinds of IOMMU implementation. So fix
> > this by not assume as->root
On Mon, Mar 20, 2017 at 11:36:39AM +0800, Jason Wang wrote:
> We assumes the iommu_ops were attached to the root region of address
> space. This may not true for all kinds of IOMMU implementation. So fix
> this by not assume as->root has iommu_ops and:
>
> - register a memory listener to dma_as
>
On Mon, Mar 20, 2017 at 11:36:38AM +0800, Jason Wang wrote:
> We have a specific memory region for DMAR now, so it's wrong to
> trigger the notifier with the root region.
>
> Cc: Michael S. Tsirkin
> Cc: Paolo Bonzini
> Cc: Richard Henderson
> Cc: Eduardo Habkost
> Signed-off-by: Jason Wang
We assumes the iommu_ops were attached to the root region of address
space. This may not true for all kinds of IOMMU implementation. So fix
this by not assume as->root has iommu_ops and:
- register a memory listener to dma_as
- during region_add, if it's a region of IOMMU, register a specific
IO
Hi:
This series is a fixup for vfio enablement series which breaks vhost
device IOTLB. The main reason is that vhost device IOTLB assumes the
iommu region were alwasy as->root. Fixing by using a memory listener
to register iommu notifiers.
Please review.
Jason Wang (2):
intel_iommu: use the co
We have a specific memory region for DMAR now, so it's wrong to
trigger the notifier with the root region.
Cc: Michael S. Tsirkin
Cc: Paolo Bonzini
Cc: Richard Henderson
Cc: Eduardo Habkost
Signed-off-by: Jason Wang
---
hw/i386/intel_iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
On 10 March 2017 at 08:42, Alex Bennée wrote:
> ---
> hw/ppc/pnv.c | 1 +
> target/alpha/translate.c | 1 +
> 2 files changed, 2 insertions(+)
I'm guessing you didn't intend to post a fixup! patch without
a signoff line? :-)
thanks
-- PMM
>
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv
---
hw/ppc/pnv.c | 1 +
target/alpha/translate.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
index 09f0d22def..3fa722af82 100644
--- a/hw/ppc/pnv.c
+++ b/hw/ppc/pnv.c
@@ -21,6 +21,7 @@
#include "qapi/error.h"
#include "sysemu/sysemu.h"
#include
On Fri, Oct 28, 2016 at 01:08:32AM +0300, Michael S. Tsirkin wrote:
> On Fri, Oct 21, 2016 at 10:53:27AM +0200, Igor Mammedov wrote:
> > On Thu, 20 Oct 2016 16:51:48 -0200
> > Eduardo Habkost wrote:
> >
> > > On Thu, Oct 20, 2016 at 04:58:42PM +0200, Igor Mammedov wrote:
> > > > Currently firmwar
On Fri, Oct 21, 2016 at 10:53:27AM +0200, Igor Mammedov wrote:
> On Thu, 20 Oct 2016 16:51:48 -0200
> Eduardo Habkost wrote:
>
> > On Thu, Oct 20, 2016 at 04:58:42PM +0200, Igor Mammedov wrote:
> > > Currently firmware uses 1 byte at 0x5F offset in RTC CMOS
> > > to get number of CPUs present at
On Mon, Oct 24, 2016 at 03:53:30PM +0200, Igor Mammedov wrote:
[...]
> > -static void qdev_property_add_legacy(DeviceState *dev, Property *prop,
> > +static void qdev_class_property_add_legacy(ObjectClass *oc, Property *prop,
> > Error **errp)
>
On Fri, Oct 21, 2016 at 10:53:27AM +0200, Igor Mammedov wrote:
> On Thu, 20 Oct 2016 16:51:48 -0200
> Eduardo Habkost wrote:
>
> > On Thu, Oct 20, 2016 at 04:58:42PM +0200, Igor Mammedov wrote:
> > > Currently firmware uses 1 byte at 0x5F offset in RTC CMOS
> > > to get number of CPUs present at
On Thu, 20 Oct 2016 16:51:48 -0200
Eduardo Habkost wrote:
> On Thu, Oct 20, 2016 at 04:58:42PM +0200, Igor Mammedov wrote:
> > Currently firmware uses 1 byte at 0x5F offset in RTC CMOS
> > to get number of CPUs present at boot. However 1 byte is
> > not enough to handle more than 255 CPUs. So ad
On Thu, Oct 20, 2016 at 04:58:42PM +0200, Igor Mammedov wrote:
> Currently firmware uses 1 byte at 0x5F offset in RTC CMOS
> to get number of CPUs present at boot. However 1 byte is
> not enough to handle more than 255 CPUs. So add a new
> fw_cfg file that would allow QEMU to tell it.
> For compat
On Tue, Oct 11, 2016 at 01:41:30PM +0200, Igor Mammedov wrote:
[...]
> >
> > Oops, leftover from v5. Thanks for spotting that! Fixup below.
> >
> > Signed-off-by: Eduardo Habkost
> Reviewed-by: Igor Mammedov
Thanks. Patch + fixup applied to x86-next.
--
Eduardo
On Mon, 10 Oct 2016 13:58:25 -0300
Eduardo Habkost wrote:
> On Mon, Oct 10, 2016 at 02:25:32PM +0200, Igor Mammedov wrote:
> > On Fri, 7 Oct 2016 17:29:01 -0300
> > Eduardo Habkost wrote:
> >
> > > When probing for CPU model information, we need to reuse the code
> > > that initializes CPUID
On Mon, Oct 10, 2016 at 02:25:32PM +0200, Igor Mammedov wrote:
> On Fri, 7 Oct 2016 17:29:01 -0300
> Eduardo Habkost wrote:
>
> > When probing for CPU model information, we need to reuse the code
> > that initializes CPUID fields, but not the remaining side-effects
> > of x86_cpu_realizefn(). Mo
---
cpu-exec.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/cpu-exec.c b/cpu-exec.c
index 0e6b3d3..8b8be25 100644
--- a/cpu-exec.c
+++ b/cpu-exec.c
@@ -291,7 +291,8 @@ static inline TranslationBlock *tb_find(CPUState *cpu,
is executed. */
cpu_get_tb_cpu_state(
Hi,
Your series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.
Subject: [Qemu-devel] [PATCH] fixup! int128: Use __int128 if available
Type: series
Message-id: 1472152170-18562-1-git-send
---
ajb:
- fixup the test-128 test case
---
tests/test-int128.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/tests/test-int128.c b/tests/test-int128.c
index 4390123..b86a3c7 100644
--- a/tests/test-int128.c
+++ b/tests/test-int128.c
@@ -41,7 +41,7
Igor Mammedov writes:
> Signed-off-by: Igor Mammedov
> ---
> - add comment o exit(1) path
> ---
> util/oslib-posix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/util/oslib-posix.c b/util/oslib-posix.c
> index a60ac97..f2d4e9e 100644
> --- a/util/oslib-posix.c
> +++ b/util/oslib-po
Signed-off-by: Igor Mammedov
---
- add comment o exit(1) path
---
util/oslib-posix.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/util/oslib-posix.c b/util/oslib-posix.c
index a60ac97..f2d4e9e 100644
--- a/util/oslib-posix.c
+++ b/util/oslib-posix.c
@@ -356,6 +356,7 @@ void os_mem_preallo
On 07/07/2016 07:49 PM, Eduardo Habkost wrote:
On Thu, Jul 07, 2016 at 01:44:48PM -0300, Eduardo Habkost wrote:
Hi,
Sorry for taking so long to review it.
The patch in general looks good, except for:
On Fri, Jun 24, 2016 at 01:49:36PM +0300, Denis V. Lunev wrote:
[...]
+if (MACHINE_GET_C
On Thu, Jul 07, 2016 at 01:44:48PM -0300, Eduardo Habkost wrote:
> Hi,
>
> Sorry for taking so long to review it.
>
> The patch in general looks good, except for:
>
> On Fri, Jun 24, 2016 at 01:49:36PM +0300, Denis V. Lunev wrote:
> [...]
> > +if (MACHINE_GET_CLASS(current_machine)->hot_add_
On Mon, May 30, 2016 at 05:22:29PM +0200, Igor Mammedov wrote:
> with all header changes merged in current master (d6550e9ed2)
> above patch breaks compilation with:
> exec.c: In function ‘cpu_exec_exit’:
> exec.c:661:9: error: implicit declaration of function ‘vmstate_unregister’
> [-Werror=i
with all header changes merged in current master (d6550e9ed2)
above patch breaks compilation with:
exec.c: In function ‘cpu_exec_exit’:
exec.c:661:9: error: implicit declaration of function ‘vmstate_unregister’
[-Werror=implicit-function-declaration]
vmstate_unregister(NULL, cc->vmsd,
This is a fixup patch intended to be squashed into the "linux-user:
Provide safe_syscall for fixing races between signalsand syscalls"
patch.
Fix compilation on non-x86-64 hosts by:
* only adding linux-user/host/$ARCH to the include path if it exists
* providing a fallback hostdep.h header in li
On 05/11/2016 06:06 AM, Sergey Fedorov wrote:
From: Sergey Fedorov
Eliminate 'code_write_count' as well.
Signed-off-by: Sergey Fedorov
Signed-off-by: Sergey Fedorov
---
Merged.
r~
From: Sergey Fedorov
Eliminate 'code_write_count' as well.
Signed-off-by: Sergey Fedorov
Signed-off-by: Sergey Fedorov
---
This series is based on commit
40f646483a11 (cpu-exec: Remove relic orphaned comment)
from
git://github.com/rth7680/qemu.git tcg-next
translate-all.c | 4 ++--
Eric Blake writes:
> [no change to commit message]
>
> Signed-off-by: Eric Blake
> ---
> include/qapi/visitor.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/qapi/visitor.h b/include/qapi/visitor.h
> index 0bb2fe1..2211637 100644
> --- a/include/qapi/visitor
On 05/04/2016 08:05 AM, Eric Blake wrote:
> [no change to commit message]
>
> Signed-off-by: Eric Blake
> ---
> include/qapi/visitor.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/qapi/visitor.h b/include/qapi/visitor.h
> index 0bb2fe1..2211637 100644
> ---
[no change to commit message]
Signed-off-by: Eric Blake
---
include/qapi/visitor.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/qapi/visitor.h b/include/qapi/visitor.h
index 0bb2fe1..2211637 100644
--- a/include/qapi/visitor.h
+++ b/include/qapi/visitor.h
@@ -174
On 02/05/16 00:27, Sergey Fedorov wrote:
> From: Sergey Fedorov
>
> Signed-off-by: Sergey Fedorov
> Signed-off-by: Sergey Fedorov
Please ignore this patch, the correct one is v2.
Kind regards,
Sergey
> ---
>
> tcg/mips/tcg-target.inc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
From: Sergey Fedorov
Signed-off-by: Sergey Fedorov
Signed-off-by: Sergey Fedorov
---
tcg/mips/tcg-target.inc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tcg/mips/tcg-target.inc.c b/tcg/mips/tcg-target.inc.c
index b0440b9c5a79..b514cd7114d2 100644
--- a/tcg/mips/tcg-t
On Tue, 02/23 10:42, Paolo Bonzini wrote:
>
>
> On 23/02/2016 06:39, Fam Zheng wrote:
> > BTW, could you also explain the blk_mig_lock() question (*) I had?
> >
> > *: https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg03317.html
>
> Sorry, missed that:
>
> >
> >> @@ -597,21 +627,28 @@
On 23/02/2016 06:39, Fam Zheng wrote:
> BTW, could you also explain the blk_mig_lock() question (*) I had?
>
> *: https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg03317.html
Sorry, missed that:
>
>> @@ -597,21 +627,28 @@ static void block_migration_cleanup(void *opaque)
>> {
>>
On Fri, 02/19 16:10, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> migration/block.c | 14 ++
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/migration/block.c b/migration/block.c
> index 3bfa908..eea4788 100644
> --- a/migration/block.c
> +++ b/migr
Signed-off-by: Paolo Bonzini
---
migration/block.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/migration/block.c b/migration/block.c
index 3bfa908..eea4788 100644
--- a/migration/block.c
+++ b/migration/block.c
@@ -54,6 +54,7 @@ typedef struct BlkMigDevStat
Signed-off-by: Markus Armbruster
---
tests/libqtest.c | 5 +++--
tests/libqtest.h | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/tests/libqtest.c b/tests/libqtest.c
index c52ceb2..fa314e1 100644
--- a/tests/libqtest.c
+++ b/tests/libqtest.c
@@ -760,14 +760,15 @@ void qt
Rather than making 2/3 callers explode a list just to have it
be reconstructed, instead fix the remaining caller to wrap its
arguments in a list.
Signed-off-by: Eric Blake
---
Markus was right
scripts/qapi.py | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/scri
Whitelist must now include implicit names, and update the testsuite
to use names that match returns-whitelist
Signed-off-by: Eric Blake
---
To be applied on top of Markus' fixup, if we indeed want to drop
info['name'] and allow implicit names in the whitelist.
scripts/qapi.py
Eric Blake writes:
> On 11/19/2015 01:10 AM, Markus Armbruster wrote:
>> Eric Blake writes:
>>
>>> [Replace the old commit message with this:]
>>
>> Fixup patch squashed, commit message replaced.
>
> The version of the patch currently on qapi-next (id 22c38fe) missed the
> addition of the new
On 11/19/2015 01:10 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> [Replace the old commit message with this:]
>
> Fixup patch squashed, commit message replaced.
The version of the patch currently on qapi-next (id 22c38fe) missed the
addition of the new tests/qapi-schema/reserved-enum-q
On 11/19/2015 06:32 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> [Replace the old commit message with this:]
>>
>> qapi: Forbid case-insensitive clashes
>>
>> However, we DO have to care about the fact that we have a
>> command 'stop' and an event 'STOP' (currently the only case
>> col
Eric Blake writes:
> On 11/19/2015 01:58 AM, Markus Armbruster wrote:
>> Eric Blake writes:
>>
>>> [If we squash, replace the old commit message with this; you'll
>>> also have some merge conflicts in 29/36 and 30/36. Note that
>>> while this mail is net lines added, squashing would still resu
On 11/19/2015 01:58 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> [If we squash, replace the old commit message with this; you'll
>> also have some merge conflicts in 29/36 and 30/36. Note that
>> while this mail is net lines added, squashing would still result
>> in a net reduction:
>>
Eric Blake writes:
> [Replace the old commit message with this:]
>
> qapi: Forbid case-insensitive clashes
>
> In general, designing user interfaces that rely on case
> distinction is poor practice. Another benefit of enforcing
> a restriction against case-insensitive clashes is that we
> no lon
Markus Armbruster writes:
> Eric Blake writes:
[...]
>> diff --git a/qobject/qobject.c b/qobject/qobject.c
>> new file mode 100644
>> index 000..db86571
>> --- /dev/null
>> +++ b/qobject/qobject.c
>> @@ -0,0 +1,26 @@
>> +/*
>> + * QObject
>> + *
>> + * Copyright (C) 2015 Red Hat, Inc.
>> + *
Eric Blake writes:
> [If we squash, replace the old commit message with this; you'll
> also have some merge conflicts in 29/36 and 30/36. Note that
> while this mail is net lines added, squashing would still result
> in a net reduction:
> 16 files changed, 67 insertions(+), 83 deletions(-)
> ]
Eric Blake writes:
> [Replace the old commit message with this:]
Fixup patch squashed, commit message replaced.
[keep the original commit body, but change the title:]
qapi: Convert QType into QAPI built-in enum type
Signed-off-by: Eric Blake
---
include/qemu/typedefs.h | 1 +
scripts/qapi-types.py | 3 +--
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/qemu/typedefs.h b/include/
[If we squash, replace the old commit message with this; you'll
also have some merge conflicts in 29/36 and 30/36. Note that
while this mail is net lines added, squashing would still result
in a net reduction:
16 files changed, 67 insertions(+), 83 deletions(-)
]
qapi: Simplify QObject
The QObj
[Replace the old commit message with this:]
qapi: Forbid case-insensitive clashes
In general, designing user interfaces that rely on case
distinction is poor practice. Another benefit of enforcing
a restriction against case-insensitive clashes is that we
no longer have to worry about the situati
[Replace the old commit message with this:]
qapi: Tighten the regex on valid names
We already documented that qapi names should match specific
patterns (such as starting with a letter unless it was an enum
value or a downstream extension). Tighten that from a suggestion
into a hard requirement,
1 - 100 of 129 matches
Mail list logo
