Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-21 Thread Stefan Hajnoczi
On Tue, Mar 20, 2012 at 5:11 PM, Lee Essen wrote: > On 20/03/2012 16:59, Stefan Hajnoczi wrote: >> >> On Mon, Mar 19, 2012 at 1:35 PM, Lee Essen >>  wrote: >>> >>> On 19 Mar 2012, at 12:32, Andreas Färber wrote: >>> Am 19.03.2012 13:05, schrieb Lee Essen: In my original (way-too-long) pa

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-20 Thread Lee Essen
On 20/03/2012 16:59, Stefan Hajnoczi wrote: On Mon, Mar 19, 2012 at 1:35 PM, Lee Essen wrote: On 19 Mar 2012, at 12:32, Andreas Färber wrote: Am 19.03.2012 13:05, schrieb Lee Essen: In my original (way-too-long) patch for Illumos I included fixes for both of the above, the approach I took wa

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-20 Thread Stefan Hajnoczi
On Mon, Mar 19, 2012 at 1:35 PM, Lee Essen wrote: > On 19 Mar 2012, at 12:32, Andreas Färber wrote: > >> Am 19.03.2012 13:05, schrieb Lee Essen: >>> On 19 Mar 2012, at 11:59, Stefan Hajnoczi wrote: >>> I'm going to spend some time today reviewing recent tracing patches. I'd prefer to mov

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-19 Thread Lee Essen
On 19 Mar 2012, at 12:32, Andreas Färber wrote: > Am 19.03.2012 13:05, schrieb Lee Essen: >> On 19 Mar 2012, at 11:59, Stefan Hajnoczi wrote: >> >>> I'm going to spend some time today reviewing recent tracing patches. >>> I'd prefer to move to a Python version of tracetool rather than worry >>> a

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-19 Thread Andreas Färber
Am 19.03.2012 13:40, schrieb Stefan Weil: > Am 19.03.2012 13:05, schrieb Lee Essen: >> On 19 Mar 2012, at 11:59, Stefan Hajnoczi wrote: >> >>> On Fri, Mar 16, 2012 at 12:29 PM, Lee Essen >>> wrote: Signed-off-by: Lee Essen --- scripts/tracetool | 2 +- 1 files changed

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-19 Thread Stefan Weil
Am 19.03.2012 13:05, schrieb Lee Essen: On 19 Mar 2012, at 11:59, Stefan Hajnoczi wrote: On Fri, Mar 16, 2012 at 12:29 PM, Lee Essen wrote: Signed-off-by: Lee Essen --- scripts/tracetool | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) I'm going to spend some time today reviewing

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-19 Thread Andreas Färber
Am 19.03.2012 13:05, schrieb Lee Essen: > On 19 Mar 2012, at 11:59, Stefan Hajnoczi wrote: > >> I'm going to spend some time today reviewing recent tracing patches. >> I'd prefer to move to a Python version of tracetool rather than worry >> about the shell quirks across all host platforms. >> >> If

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-19 Thread Stefan Hajnoczi
On Mon, Mar 19, 2012 at 12:05 PM, Lee Essen wrote: > On 19 Mar 2012, at 11:59, Stefan Hajnoczi wrote: > >> On Fri, Mar 16, 2012 at 12:29 PM, Lee Essen >> wrote: >>> Signed-off-by: Lee Essen >>> >>> --- >>> >>>  scripts/tracetool |    2 +- >>>  1 files changed, 1 insertions(+), 1 deletions(-) >>

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-19 Thread Lee Essen
On 19 Mar 2012, at 11:59, Stefan Hajnoczi wrote: > On Fri, Mar 16, 2012 at 12:29 PM, Lee Essen wrote: >> Signed-off-by: Lee Essen >> >> --- >> >> scripts/tracetool |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) > > I'm going to spend some time today reviewing recent tracing p

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-19 Thread Stefan Hajnoczi
On Fri, Mar 16, 2012 at 12:29 PM, Lee Essen wrote: > Signed-off-by: Lee Essen > > --- > >  scripts/tracetool |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) I'm going to spend some time today reviewing recent tracing patches. I'd prefer to move to a Python version of tracetool rath

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-16 Thread Eric Blake
On 03/16/2012 07:18 AM, Paolo Bonzini wrote: > Il 16/03/2012 13:29, Lee Essen ha scritto: >> @@ -123,7 +123,7 @@ get_argc() >> # Get the format string including double quotes for a trace event >> get_fmt() >> { >> -puts "${1#*)}" This says to call puts with the first argument of get_fmt, ex

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-16 Thread Andreas Färber
Am 16.03.2012 14:19, schrieb Paolo Bonzini: > Il 16/03/2012 14:00, Lee Essen ha scritto: >> /tmp/patch/qemu/scripts/tracetool[520]: local: not found [No such file or >> directory] >> /tmp/patch/qemu/scripts/tracetool[66]: local: not found [No such file or >> directory] >> /tmp/patch/qemu/scripts/

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-16 Thread Andreas Färber
Am 16.03.2012 14:00, schrieb Lee Essen: > On 16 Mar 2012, at 12:44, Andreas Färber wrote: > >> Am 16.03.2012 13:29, schrieb Lee Essen: >>> Signed-off-by: Lee Essen >>> >>> --- >>> >>> scripts/tracetool |2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/scripts/tra

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-16 Thread Paolo Bonzini
Il 16/03/2012 14:00, Lee Essen ha scritto: > /tmp/patch/qemu/scripts/tracetool[520]: local: not found [No such file or > directory] > /tmp/patch/qemu/scripts/tracetool[66]: local: not found [No such file or > directory] > /tmp/patch/qemu/scripts/tracetool[136]: local: not found [No such file or

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-16 Thread Paolo Bonzini
Il 16/03/2012 13:29, Lee Essen ha scritto: > @@ -123,7 +123,7 @@ get_argc() > # Get the format string including double quotes for a trace event > get_fmt() > { > -puts "${1#*)}" > +puts "${1#*}" > } > Eric, can you look at this? Is it a bashism or a Solaris bug? I would write it, t

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-16 Thread Lee Essen
On 16 Mar 2012, at 12:44, Andreas Färber wrote: > Am 16.03.2012 13:29, schrieb Lee Essen: >> Signed-off-by: Lee Essen >> >> --- >> >> scripts/tracetool |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/scripts/tracetool b/scripts/tracetool >> index 65bd0a1..2e43d

Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-16 Thread Andreas Färber
Am 16.03.2012 13:29, schrieb Lee Essen: > Signed-off-by: Lee Essen > > --- > > scripts/tracetool |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/scripts/tracetool b/scripts/tracetool > index 65bd0a1..2e43d05 100755 > --- a/scripts/tracetool > +++ b/scripts/tracetool

[Qemu-devel] [PATCH] fix incorrect bracket in tracetool

2012-03-16 Thread Lee Essen
Signed-off-by: Lee Essen --- scripts/tracetool |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/tracetool b/scripts/tracetool index 65bd0a1..2e43d05 100755 --- a/scripts/tracetool +++ b/scripts/tracetool @@ -123,7 +123,7 @@ get_argc() # Get the format string in