Re: [Qemu-devel] [PATCH] fix build errors when we enable acpi_piix4 debug

2011-04-03 Thread Aurelien Jarno
On Sat, Apr 02, 2011 at 08:41:28AM +0900, Isaku Yamahata wrote: > Sorry for late comment after the commit. > PRIx64 shouldn't be used instead of cast? It what I thought first, but given the port number is a small 16-bit value, the cast is probably as good as the PRIx64. Also part of the already ex

Re: [Qemu-devel] [PATCH] fix build errors when we enable acpi_piix4 debug

2011-04-01 Thread Isaku Yamahata
Sorry for late comment after the commit. PRIx64 shouldn't be used instead of cast? On Fri, Apr 01, 2011 at 10:08:23PM +0200, Aurelien Jarno wrote: > On Mon, Feb 28, 2011 at 10:22:33AM +0800, Wen Congyang wrote: > > I enable acpi_piix4 debug, and got the following build errors: > > # make > > CC

Re: [Qemu-devel] [PATCH] fix build errors when we enable acpi_piix4 debug

2011-04-01 Thread Aurelien Jarno
On Mon, Feb 28, 2011 at 10:22:33AM +0800, Wen Congyang wrote: > I enable acpi_piix4 debug, and got the following build errors: > # make > CClibhw64/acpi_piix4.o > cc1: warnings being treated as errors > /home/wency/source/qemu/hw/acpi_piix4.c: In function ‘pm_ioport_write’: > /home/wency/sour

[Qemu-devel] [PATCH] fix build errors when we enable acpi_piix4 debug

2011-02-27 Thread Wen Congyang
I enable acpi_piix4 debug, and got the following build errors: # make CClibhw64/acpi_piix4.o cc1: warnings being treated as errors /home/wency/source/qemu/hw/acpi_piix4.c: In function ‘pm_ioport_write’: /home/wency/source/qemu/hw/acpi_piix4.c:193: error: format ‘%04x’ expects type ‘unsigned