Re: [Qemu-devel] [PATCH] fdc: always compile-check debug prints

2016-02-08 Thread John Snow
On 02/08/2016 06:11 PM, Eric Blake wrote: > On 02/08/2016 03:45 PM, John Snow wrote: >> Coverity noticed that some variables are only used by debug prints, and >> called them unused. Always compile the print statements. >> >> Bonus: Fix a printf I broke. > > Might be nice to mention the commit t

Re: [Qemu-devel] [PATCH] fdc: always compile-check debug prints

2016-02-08 Thread Eric Blake
On 02/08/2016 03:45 PM, John Snow wrote: > Coverity noticed that some variables are only used by debug prints, and > called them unused. Always compile the print statements. > > Bonus: Fix a printf I broke. Might be nice to mention the commit that broke it. > > Signed-off-by: John Snow > --- >

[Qemu-devel] [PATCH] fdc: always compile-check debug prints

2016-02-08 Thread John Snow
Coverity noticed that some variables are only used by debug prints, and called them unused. Always compile the print statements. Bonus: Fix a printf I broke. Signed-off-by: John Snow --- hw/block/fdc.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/hw/block/