Re: [Qemu-devel] [PATCH] exec-obsolete: fix length handling

2012-01-29 Thread Avi Kivity
On 01/29/2012 03:39 PM, Blue Swirl wrote: > >> >> +++ b/exec-obsolete.h > >> >> @@ -81,11 +81,10 @@ static inline void > >> >> cpu_physical_memory_set_dirty_range(ram_addr_t start, > >> >> int dirty_flags) > >> >> { > >> >> uint8_t *p; >

Re: [Qemu-devel] [PATCH] exec-obsolete: fix length handling

2012-01-29 Thread Blue Swirl
On Sun, Jan 29, 2012 at 13:20, Avi Kivity wrote: > On 01/29/2012 03:16 PM, Blue Swirl wrote: >> On Sun, Jan 29, 2012 at 12:08, Avi Kivity wrote: >> > On 01/28/2012 08:13 PM, Blue Swirl wrote: >> >> Fix suspend/resume broken by off-by-one error in >> >> 59abb06198ee9471e29c970f294eae80c0b39be1. >>

Re: [Qemu-devel] [PATCH] exec-obsolete: fix length handling

2012-01-29 Thread Avi Kivity
On 01/29/2012 03:16 PM, Blue Swirl wrote: > On Sun, Jan 29, 2012 at 12:08, Avi Kivity wrote: > > On 01/28/2012 08:13 PM, Blue Swirl wrote: > >> Fix suspend/resume broken by off-by-one error in > >> 59abb06198ee9471e29c970f294eae80c0b39be1. > >> > >> Adjust the loop so that it handles correctly the

[Qemu-devel] [PATCH] exec-obsolete: fix length handling

2012-01-29 Thread Blue Swirl
Fix suspend/resume broken by off-by-one error in 59abb06198ee9471e29c970f294eae80c0b39be1, based on patch by Stefan Berger. Reported-by: Stefan Berger Signed-off-by: Blue Swirl --- exec-obsolete.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/exec-obsolete.h b/exec

Re: [Qemu-devel] [PATCH] exec-obsolete: fix length handling

2012-01-29 Thread Blue Swirl
On Sun, Jan 29, 2012 at 12:08, Avi Kivity wrote: > On 01/28/2012 08:13 PM, Blue Swirl wrote: >> Fix suspend/resume broken by off-by-one error in >> 59abb06198ee9471e29c970f294eae80c0b39be1. >> >> Adjust the loop so that it handles correctly the case >> start = (ram_addr_t)-TARGET_PAGE_SIZE, length

Re: [Qemu-devel] [PATCH] exec-obsolete: fix length handling

2012-01-29 Thread Avi Kivity
On 01/28/2012 08:13 PM, Blue Swirl wrote: > Fix suspend/resume broken by off-by-one error in > 59abb06198ee9471e29c970f294eae80c0b39be1. > > Adjust the loop so that it handles correctly the case > start = (ram_addr_t)-TARGET_PAGE_SIZE, length = TARGET_PAGE_SIZE. > > Reported-by: Stefan Berger > Si

Re: [Qemu-devel] [PATCH] exec-obsolete: fix length handling

2012-01-29 Thread Avi Kivity
On 01/29/2012 01:37 PM, Blue Swirl wrote: > On Sun, Jan 29, 2012 at 10:22, Avi Kivity wrote: > > On 01/28/2012 08:13 PM, Blue Swirl wrote: > >> Fix suspend/resume broken by off-by-one error in > >> 59abb06198ee9471e29c970f294eae80c0b39be1. > >> > >> Adjust the loop so that it handles correctly the

Re: [Qemu-devel] [PATCH] exec-obsolete: fix length handling

2012-01-29 Thread Blue Swirl
On Sun, Jan 29, 2012 at 10:22, Avi Kivity wrote: > On 01/28/2012 08:13 PM, Blue Swirl wrote: >> Fix suspend/resume broken by off-by-one error in >> 59abb06198ee9471e29c970f294eae80c0b39be1. >> >> Adjust the loop so that it handles correctly the case >> start = (ram_addr_t)-TARGET_PAGE_SIZE, length

Re: [Qemu-devel] [PATCH] exec-obsolete: fix length handling

2012-01-29 Thread Avi Kivity
On 01/28/2012 08:13 PM, Blue Swirl wrote: > Fix suspend/resume broken by off-by-one error in > 59abb06198ee9471e29c970f294eae80c0b39be1. > > Adjust the loop so that it handles correctly the case > start = (ram_addr_t)-TARGET_PAGE_SIZE, length = TARGET_PAGE_SIZE. Is the ram_addr_t even legal? ram a

[Qemu-devel] [PATCH] exec-obsolete: fix length handling

2012-01-28 Thread Blue Swirl
Fix suspend/resume broken by off-by-one error in 59abb06198ee9471e29c970f294eae80c0b39be1. Adjust the loop so that it handles correctly the case start = (ram_addr_t)-TARGET_PAGE_SIZE, length = TARGET_PAGE_SIZE. Reported-by: Stefan Berger Signed-off-by: Blue Swirl --- exec-obsolete.h | 10 +++