Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-24 Thread TeLeMan
On Fri, May 25, 2012 at 3:51 AM, Anthony Liguori wrote: > On 05/24/2012 02:42 PM, Stefan Weil wrote: >> >> Am 24.05.2012 20:36, schrieb Anthony Liguori: >>> >>> On 05/24/2012 01:12 PM, Stefan Weil wrote: This discussion looks strange for me. >>> >>> >>> I'm not going to commit patches wi

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-24 Thread Anthony Liguori
On 05/24/2012 02:42 PM, Stefan Weil wrote: Am 24.05.2012 20:36, schrieb Anthony Liguori: On 05/24/2012 01:12 PM, Stefan Weil wrote: This discussion looks strange for me. I'm not going to commit patches with a Signed-off-by if I know the name is an alias. DCO requires the use of a real name.

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-24 Thread Stefan Weil
Am 24.05.2012 20:36, schrieb Anthony Liguori: On 05/24/2012 01:12 PM, Stefan Weil wrote: This discussion looks strange for me. I'm not going to commit patches with a Signed-off-by if I know the name is an alias. DCO requires the use of a real name. DCO is an important part of ensuring the

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-24 Thread Anthony Liguori
On 05/24/2012 01:12 PM, Stefan Weil wrote: Am 24.05.2012 15:35, schrieb Andreas Färber: Am 24.05.2012 04:12, schrieb TeLeMan: I won't use my Chinese name because I think it's my privacy. That exactly is touching the core point: Signed-off-by is about transparency and taking responsibility for

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-24 Thread Stefan Weil
Am 24.05.2012 15:35, schrieb Andreas Färber: Am 24.05.2012 04:12, schrieb TeLeMan: I won't use my Chinese name because I think it's my privacy. That exactly is touching the core point: Signed-off-by is about transparency and taking responsibility for your actions, not hiding in anonymity. It's

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-24 Thread Andreas Färber
Am 24.05.2012 04:12, schrieb TeLeMan: > I won't use > my Chinese name because I think it's my privacy. That exactly is touching the core point: Signed-off-by is about transparency and taking responsibility for your actions, not hiding in anonymity. It's a certification of whom the code came from a

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread Jan Kiszka
On 2012-05-23 23:00, Jan Kiszka wrote: > On 2012-05-23 22:29, TeLeMan wrote: >> On Thu, May 24, 2012 at 1:36 AM, Jan Kiszka wrote: >>> On 2012-05-23 13:02, Jan Kiszka wrote: On 2012-05-23 11:11, TeLeMan wrote: > On Wed, May 23, 2012 at 7:22 PM, Jan Kiszka > wrote: >> On 2012-05-

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread TeLeMan
On Thu, May 24, 2012 at 10:00 AM, Jan Kiszka wrote: > On 2012-05-23 22:29, TeLeMan wrote: >> On Thu, May 24, 2012 at 1:36 AM, Jan Kiszka wrote: >>> On 2012-05-23 13:02, Jan Kiszka wrote: On 2012-05-23 11:11, TeLeMan wrote: > On Wed, May 23, 2012 at 7:22 PM, Jan Kiszka > wrote:

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread TeLeMan
On Thu, May 24, 2012 at 4:44 AM, Anthony Liguori wrote: > On 05/23/2012 03:28 PM, Blue Swirl wrote: >> >> On Wed, May 23, 2012 at 8:04 PM, Andreas Färber  wrote: >>> >>> Am 23.05.2012 21:40, schrieb Blue Swirl: On Wed, May 23, 2012 at 3:41 AM, Andreas Färber  wrote: > > Am 1

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread Jan Kiszka
On 2012-05-23 22:29, TeLeMan wrote: > On Thu, May 24, 2012 at 1:36 AM, Jan Kiszka wrote: >> On 2012-05-23 13:02, Jan Kiszka wrote: >>> On 2012-05-23 11:11, TeLeMan wrote: On Wed, May 23, 2012 at 7:22 PM, Jan Kiszka wrote: > On 2012-05-23 04:09, TeLeMan wrote: >> On Wed, May 23, 2012

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread TeLeMan
On Thu, May 24, 2012 at 1:36 AM, Jan Kiszka wrote: > On 2012-05-23 13:02, Jan Kiszka wrote: >> On 2012-05-23 11:11, TeLeMan wrote: >>> On Wed, May 23, 2012 at 7:22 PM, Jan Kiszka wrote: On 2012-05-23 04:09, TeLeMan wrote: > On Wed, May 23, 2012 at 11:41 AM, Andreas Färber wrote: >>

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread Anthony Liguori
On 05/23/2012 03:28 PM, Blue Swirl wrote: On Wed, May 23, 2012 at 8:04 PM, Andreas Färber wrote: Am 23.05.2012 21:40, schrieb Blue Swirl: On Wed, May 23, 2012 at 3:41 AM, Andreas Färber wrote: Am 18.05.2012 11:49, schrieb TeLeMan: This breakage was introduced by the commit "memory: make phy

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread Blue Swirl
On Wed, May 23, 2012 at 8:04 PM, Andreas Färber wrote: > Am 23.05.2012 21:40, schrieb Blue Swirl: >> On Wed, May 23, 2012 at 3:41 AM, Andreas Färber wrote: >>> Am 18.05.2012 11:49, schrieb TeLeMan: This breakage was introduced by the commit "memory: make phys_page_find() return an unadj

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread Andreas Färber
Am 23.05.2012 21:40, schrieb Blue Swirl: > On Wed, May 23, 2012 at 3:41 AM, Andreas Färber wrote: >> Am 18.05.2012 11:49, schrieb TeLeMan: >>> This breakage was introduced by the commit "memory: make >>> phys_page_find() return an unadjusted". >> >> You seem to have found the origin of your proble

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread Blue Swirl
On Wed, May 23, 2012 at 3:41 AM, Andreas Färber wrote: > Am 18.05.2012 11:49, schrieb TeLeMan: >> This breakage was introduced by the commit "memory: make >> phys_page_find() return an unadjusted". > > You seem to have found the origin of your problem. If you also mention > the commit hash in your

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread Jan Kiszka
On 2012-05-23 13:02, Jan Kiszka wrote: > On 2012-05-23 11:11, TeLeMan wrote: >> On Wed, May 23, 2012 at 7:22 PM, Jan Kiszka wrote: >>> On 2012-05-23 04:09, TeLeMan wrote: On Wed, May 23, 2012 at 11:41 AM, Andreas Färber wrote: > Am 18.05.2012 11:49, schrieb TeLeMan: >> This breakage

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread Jan Kiszka
On 2012-05-23 11:11, TeLeMan wrote: > On Wed, May 23, 2012 at 7:22 PM, Jan Kiszka wrote: >> On 2012-05-23 04:09, TeLeMan wrote: >>> On Wed, May 23, 2012 at 11:41 AM, Andreas Färber wrote: Am 18.05.2012 11:49, schrieb TeLeMan: > This breakage was introduced by the commit "memory: make >>>

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread TeLeMan
On Wed, May 23, 2012 at 7:22 PM, Jan Kiszka wrote: > On 2012-05-23 04:09, TeLeMan wrote: >> On Wed, May 23, 2012 at 11:41 AM, Andreas Färber wrote: >>> Am 18.05.2012 11:49, schrieb TeLeMan: This breakage was introduced by the commit "memory: make phys_page_find() return an unadjusted".

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread Jan Kiszka
On 2012-05-23 04:09, TeLeMan wrote: > On Wed, May 23, 2012 at 11:41 AM, Andreas Färber wrote: >> Am 18.05.2012 11:49, schrieb TeLeMan: >>> This breakage was introduced by the commit "memory: make >>> phys_page_find() return an unadjusted". >> >> You seem to have found the origin of your problem. I

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-23 Thread TeLeMan
On Wed, May 23, 2012 at 11:41 AM, Andreas Färber wrote: > Am 18.05.2012 11:49, schrieb TeLeMan: >> This breakage was introduced by the commit "memory: make >> phys_page_find() return an unadjusted". > > You seem to have found the origin of your problem. If you also mention > the commit hash in you

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-22 Thread Andreas Färber
Am 18.05.2012 11:49, schrieb TeLeMan: > This breakage was introduced by the commit "memory: make > phys_page_find() return an unadjusted". You seem to have found the origin of your problem. If you also mention the commit hash in your commit message then certain frontends (gitk, repo.or.cz) will di

Re: [Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-22 Thread TeLeMan
On Friday, May 18, 2012, TeLeMan wrote: > This breakage was introduced by the commit "memory: make > phys_page_find() return an unadjusted". > > Signed-off-by: TeLeMan > --- > exec.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/exec.c b/exec.c > index 0607c9b..ad

[Qemu-devel] [PATCH] exec: fix breakpoint_invalidate() breakage

2012-05-18 Thread TeLeMan
This breakage was introduced by the commit "memory: make phys_page_find() return an unadjusted". Signed-off-by: TeLeMan --- exec.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/exec.c b/exec.c index 0607c9b..ad99476 100644 --- a/exec.c +++ b/exec.c @@ -1475,7 +1475,8 @