Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-11-02 Thread Alexander Graf
Avi Kivity wrote: > On 11/02/2011 08:23 PM, Alexander Graf wrote: > >>> Plus, remove the tachyons from your system. >>> >>> >> Ah, yes. That helped a lot. Damn those tachyons! >> > > They're still there. > > (I hate explaining a joke, but your system clock is an hour ahead) >

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-11-02 Thread Avi Kivity
On 11/02/2011 08:23 PM, Alexander Graf wrote: > > > > Plus, remove the tachyons from your system. > > > > Ah, yes. That helped a lot. Damn those tachyons! They're still there. (I hate explaining a joke, but your system clock is an hour ahead) -- error compiling committee.c: too many argument

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-11-02 Thread Alexander Graf
Avi Kivity wrote: > On 11/02/2011 07:12 PM, Avi Kivity wrote: > >> On 11/02/2011 08:10 PM, Alexander Graf wrote: >> >>> Anthony Liguori wrote: >>> On 09/27/2011 09:26 AM, Avi Kivity wrote: > Has no business in hw/. > > Signed-off-by: Avi Kivity >

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-11-02 Thread Avi Kivity
On 11/02/2011 07:12 PM, Avi Kivity wrote: > On 11/02/2011 08:10 PM, Alexander Graf wrote: > > Anthony Liguori wrote: > > > On 09/27/2011 09:26 AM, Avi Kivity wrote: > > >> Has no business in hw/. > > >> > > >> Signed-off-by: Avi Kivity > > > > > > Applied. Thanks. > > > > make: *** No rule to make

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-11-02 Thread Avi Kivity
On 11/02/2011 08:10 PM, Alexander Graf wrote: > Anthony Liguori wrote: > > On 09/27/2011 09:26 AM, Avi Kivity wrote: > >> Has no business in hw/. > >> > >> Signed-off-by: Avi Kivity > > > > Applied. Thanks. > > make: *** No rule to make target > `/home/agraf/release/qemu/hw/event_notifier.c', need

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-11-02 Thread Alexander Graf
Anthony Liguori wrote: > On 09/27/2011 09:26 AM, Avi Kivity wrote: >> Has no business in hw/. >> >> Signed-off-by: Avi Kivity > > Applied. Thanks. make: *** No rule to make target `/home/agraf/release/qemu/hw/event_notifier.c', needed by `event_notifier.o'. Stop. make: *** Waiting for unfinished

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-11-01 Thread Anthony Liguori
On 09/27/2011 09:26 AM, Avi Kivity wrote: Has no business in hw/. Signed-off-by: Avi Kivity Applied. Thanks. Regards, Anthony Liguori --- hw/event_notifier.c => event_notifier.c |1 - hw/event_notifier.h => event_notifier.h |0 2 files changed, 0 insertions(+), 1 deletions(-

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-09-28 Thread Stefan Hajnoczi
On Tue, Sep 27, 2011 at 10:23 PM, Anthony Liguori wrote: > On 09/27/2011 11:39 AM, Paolo Bonzini wrote: >> >> On 09/27/2011 06:05 PM, Anthony Liguori wrote: >>> >>> Actually, for posix-aio, we can just switch to using g_idle_add(). >>> g_idle_add() uses g_source_attach which is thread safe. g_idle

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-09-28 Thread Paolo Bonzini
On 09/28/2011 09:52 AM, Jan Kiszka wrote: > You can probably assume that qemu_notify_event (and dually the read in > the main loop) are resp. write/read memory barriers. Or even full. > > If we switch entirely to GSources, it would be nice to use them. But > since we aren't, and our main lo

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-09-28 Thread Jan Kiszka
On 2011-09-28 08:27, Paolo Bonzini wrote: > On 09/27/2011 11:23 PM, Anthony Liguori wrote: >> On 09/27/2011 11:39 AM, Paolo Bonzini wrote: >>> On 09/27/2011 06:05 PM, Anthony Liguori wrote: Actually, for posix-aio, we can just switch to using g_idle_add(). g_idle_add() uses g_source_attac

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-09-27 Thread Paolo Bonzini
On 09/27/2011 11:23 PM, Anthony Liguori wrote: On 09/27/2011 11:39 AM, Paolo Bonzini wrote: On 09/27/2011 06:05 PM, Anthony Liguori wrote: Actually, for posix-aio, we can just switch to using g_idle_add(). g_idle_add() uses g_source_attach which is thread safe. g_idle_add() gives you a thread s

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-09-27 Thread Anthony Liguori
On 09/27/2011 11:39 AM, Paolo Bonzini wrote: On 09/27/2011 06:05 PM, Anthony Liguori wrote: Actually, for posix-aio, we can just switch to using g_idle_add(). g_idle_add() uses g_source_attach which is thread safe. g_idle_add() gives you a thread safe mechanism to defer a piece of work to the ma

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-09-27 Thread Paolo Bonzini
On 09/27/2011 06:05 PM, Anthony Liguori wrote: Actually, for posix-aio, we can just switch to using g_idle_add(). g_idle_add() uses g_source_attach which is thread safe. g_idle_add() gives you a thread safe mechanism to defer a piece of work to the main loop which is really what we want here.

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-09-27 Thread Anthony Liguori
On 09/27/2011 10:28 AM, Jan Kiszka wrote: On 2011-09-27 17:17, Stefan Hajnoczi wrote: On Tue, Sep 27, 2011 at 3:26 PM, Avi Kivity wrote: Has no business in hw/. Signed-off-by: Avi Kivity --- hw/event_notifier.c => event_notifier.c |1 - hw/event_notifier.h => event_notifier.h |0

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-09-27 Thread Jan Kiszka
On 2011-09-27 17:17, Stefan Hajnoczi wrote: > On Tue, Sep 27, 2011 at 3:26 PM, Avi Kivity wrote: >> Has no business in hw/. >> >> Signed-off-by: Avi Kivity >> --- >> hw/event_notifier.c => event_notifier.c |1 - >> hw/event_notifier.h => event_notifier.h |0 >> 2 files changed, 0 inserti

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-09-27 Thread Stefan Hajnoczi
On Tue, Sep 27, 2011 at 3:26 PM, Avi Kivity wrote: > Has no business in hw/. > > Signed-off-by: Avi Kivity > --- >  hw/event_notifier.c => event_notifier.c |    1 - >  hw/event_notifier.h => event_notifier.h |    0 >  2 files changed, 0 insertions(+), 1 deletions(-) >  rename hw/event_notifier.c

[Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-09-27 Thread Avi Kivity
Has no business in hw/. Signed-off-by: Avi Kivity --- hw/event_notifier.c => event_notifier.c |1 - hw/event_notifier.h => event_notifier.h |0 2 files changed, 0 insertions(+), 1 deletions(-) rename hw/event_notifier.c => event_notifier.c (98%) rename hw/event_notifier.h => event_noti