Re: [Qemu-devel] [PATCH] ether/slirp: Avoid redefinition of the same constants

2016-01-10 Thread Jason Wang
On 01/09/2016 12:25 AM, Alex Bennée wrote: > Dr. David Alan Gilbert (git) writes: > >> From: "Dr. David Alan Gilbert" >> >> eth.h and slirp.h both define ETH_ALEN and ETH_P_IP >> rtl8139.c and eth.h both define ETH_HLEN >> >> Move the related constant (ETH_P_ARP) from slirp.h to eth.h, and >> r

Re: [Qemu-devel] [PATCH] ether/slirp: Avoid redefinition of the same constants

2016-01-08 Thread Alex Bennée
Dr. David Alan Gilbert (git) writes: > From: "Dr. David Alan Gilbert" > > eth.h and slirp.h both define ETH_ALEN and ETH_P_IP > rtl8139.c and eth.h both define ETH_HLEN > > Move the related constant (ETH_P_ARP) from slirp.h to eth.h, and > remove the duplicates; make slirp.h include eth.h Revi

[Qemu-devel] [PATCH] ether/slirp: Avoid redefinition of the same constants

2016-01-08 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" eth.h and slirp.h both define ETH_ALEN and ETH_P_IP rtl8139.c and eth.h both define ETH_HLEN Move the related constant (ETH_P_ARP) from slirp.h to eth.h, and remove the duplicates; make slirp.h include eth.h Signed-off-by: Dr. David Alan Gilbert --- hw/net/rtl81