Re: [Qemu-devel] [PATCH] e1000e: Don't zero out buffer address in rx descriptor

2016-10-20 Thread Jason Wang
On 2016年10月18日 22:27, Kevin Wolf wrote: Am 18.10.2016 um 16:10 hat Dmitry Fleytman geschrieben: > On 17 Oct 2016, at 01:35 AM, Kevin Wolf wrote: > > The e1000e emulation zeroes out any used rx descriptor and then writes a > completely newly constructed value there. By doing this,

Re: [Qemu-devel] [PATCH] e1000e: Don't zero out buffer address in rx descriptor

2016-10-20 Thread Jason Wang
On 2016年10月18日 22:10, Dmitry Fleytman wrote: On 17 Oct 2016, at 01:35 AM, Kevin Wolf wrote: The e1000e emulation zeroes out any used rx descriptor and then writes a completely newly constructed value there. By doing this, it doesn't only update the write-back area of the descriptors (as it's

Re: [Qemu-devel] [PATCH] e1000e: Don't zero out buffer address in rx descriptor

2016-10-19 Thread Dmitry Fleytman
> On 19 Oct 2016, at 13:07 PM, Kevin Wolf wrote: > > Am 19.10.2016 um 09:57 hat Dmitry Fleytman geschrieben: >> >>On 19 Oct 2016, at 10:25 AM, Kevin Wolf wrote: >> >>Am 19.10.2016 um 08:48 hat Dmitry Fleytman geschrieben: >> >> Another related thing that I noticed while deb

Re: [Qemu-devel] [PATCH] e1000e: Don't zero out buffer address in rx descriptor

2016-10-19 Thread Kevin Wolf
Am 19.10.2016 um 09:57 hat Dmitry Fleytman geschrieben: > > On 19 Oct 2016, at 10:25 AM, Kevin Wolf wrote: > > Am 19.10.2016 um 08:48 hat Dmitry Fleytman geschrieben: > >Another related thing that I noticed while debugging this and > turning on >tracing i

Re: [Qemu-devel] [PATCH] e1000e: Don't zero out buffer address in rx descriptor

2016-10-19 Thread Dmitry Fleytman
> On 19 Oct 2016, at 10:25 AM, Kevin Wolf wrote: > > Am 19.10.2016 um 08:48 hat Dmitry Fleytman geschrieben: >>Another related thing that I noticed while debugging this and turning on >>tracing is that the interrupt throttling timers kept firing even if >>there was no activity at all

Re: [Qemu-devel] [PATCH] e1000e: Don't zero out buffer address in rx descriptor

2016-10-19 Thread Kevin Wolf
Am 19.10.2016 um 08:48 hat Dmitry Fleytman geschrieben: > Another related thing that I noticed while debugging this and turning on > tracing is that the interrupt throttling timers kept firing even if > there was no activity at all. Something might be wrong, there, too. > > Next th

Re: [Qemu-devel] [PATCH] e1000e: Don't zero out buffer address in rx descriptor

2016-10-19 Thread Dmitry Fleytman
> On 18 Oct 2016, at 17:27 PM, Kevin Wolf wrote: > > Am 18.10.2016 um 16:10 hat Dmitry Fleytman geschrieben: >>On 17 Oct 2016, at 01:35 AM, Kevin Wolf wrote: >> >>The e1000e emulation zeroes out any used rx descriptor and then writes a >>completely newly constructed value there. By

Re: [Qemu-devel] [PATCH] e1000e: Don't zero out buffer address in rx descriptor

2016-10-18 Thread Kevin Wolf
Am 18.10.2016 um 16:10 hat Dmitry Fleytman geschrieben: > On 17 Oct 2016, at 01:35 AM, Kevin Wolf wrote: > > The e1000e emulation zeroes out any used rx descriptor and then writes a > completely newly constructed value there. By doing this, it doesn't only > update the write-back

Re: [Qemu-devel] [PATCH] e1000e: Don't zero out buffer address in rx descriptor

2016-10-18 Thread Dmitry Fleytman
> On 17 Oct 2016, at 01:35 AM, Kevin Wolf wrote: > > The e1000e emulation zeroes out any used rx descriptor and then writes a > completely newly constructed value there. By doing this, it doesn't only > update the write-back area of the descriptors (as it's supposed to do), > but it also clears t

[Qemu-devel] [PATCH] e1000e: Don't zero out buffer address in rx descriptor

2016-10-16 Thread Kevin Wolf
The e1000e emulation zeroes out any used rx descriptor and then writes a completely newly constructed value there. By doing this, it doesn't only update the write-back area of the descriptors (as it's supposed to do), but it also clears the buffer address, which real hardware doesn't do. The spec