Re: [Qemu-devel] [PATCH] e1000e: Do not auto-clear ICR bits which aren't set in EIAC

2018-06-15 Thread Jan Kiszka
On 2018-06-15 04:07, Jason Wang wrote: > > > On 2018年06月13日 10:29, Jason Wang wrote: >> >> >> On 2018年06月13日 10:26, Philippe Mathieu-Daudé wrote: >>> Hi Jason, >>> >>> On 06/12/2018 11:18 PM, Jason Wang wrote: On 2018年06月13日 03:00, Philippe Mathieu-Daudé wrote: > Cc'ing Jason who is also

Re: [Qemu-devel] [PATCH] e1000e: Do not auto-clear ICR bits which aren't set in EIAC

2018-06-14 Thread Jason Wang
On 2018年06月13日 10:29, Jason Wang wrote: On 2018年06月13日 10:26, Philippe Mathieu-Daudé wrote: Hi Jason, On 06/12/2018 11:18 PM, Jason Wang wrote: On 2018年06月13日 03:00, Philippe Mathieu-Daudé wrote: Cc'ing Jason who is also listed as co-maintainer:     ./scripts/get_maintainer.pl -f hw/net

Re: [Qemu-devel] [PATCH] e1000e: Do not auto-clear ICR bits which aren't set in EIAC

2018-06-12 Thread Jason Wang
On 2018年06月13日 10:26, Philippe Mathieu-Daudé wrote: Hi Jason, On 06/12/2018 11:18 PM, Jason Wang wrote: On 2018年06月13日 03:00, Philippe Mathieu-Daudé wrote: Cc'ing Jason who is also listed as co-maintainer:    ./scripts/get_maintainer.pl -f hw/net/e1000e_core.c    Dmitry Fleytman (mainta

Re: [Qemu-devel] [PATCH] e1000e: Do not auto-clear ICR bits which aren't set in EIAC

2018-06-12 Thread Philippe Mathieu-Daudé
Hi Jason, On 06/12/2018 11:18 PM, Jason Wang wrote: > On 2018年06月13日 03:00, Philippe Mathieu-Daudé wrote: >> Cc'ing Jason who is also listed as co-maintainer: >> >>    ./scripts/get_maintainer.pl -f hw/net/e1000e_core.c >>    Dmitry Fleytman (maintainer:e1000e) >>    Jason Wang (odd fixer:Networ

Re: [Qemu-devel] [PATCH] e1000e: Do not auto-clear ICR bits which aren't set in EIAC

2018-06-12 Thread Jason Wang
On 2018年06月13日 03:00, Philippe Mathieu-Daudé wrote: Cc'ing Jason who is also listed as co-maintainer: ./scripts/get_maintainer.pl -f hw/net/e1000e_core.c Dmitry Fleytman (maintainer:e1000e) Jason Wang (odd fixer:Network devices) On 06/12/2018 03:43 PM, Jan Kiszka wrote: On 2018-0

Re: [Qemu-devel] [PATCH] e1000e: Do not auto-clear ICR bits which aren't set in EIAC

2018-06-12 Thread Philippe Mathieu-Daudé
Cc'ing Jason who is also listed as co-maintainer: ./scripts/get_maintainer.pl -f hw/net/e1000e_core.c Dmitry Fleytman (maintainer:e1000e) Jason Wang (odd fixer:Network devices) On 06/12/2018 03:43 PM, Jan Kiszka wrote: > On 2018-06-12 20:38, Philippe Mathieu-Daudé wrote: >> On 06/12/2018

Re: [Qemu-devel] [PATCH] e1000e: Do not auto-clear ICR bits which aren't set in EIAC

2018-06-12 Thread Jan Kiszka
On 2018-06-12 20:38, Philippe Mathieu-Daudé wrote: > On 06/12/2018 03:30 PM, Jan Kiszka wrote: >> On 2018-06-12 20:11, Philippe Mathieu-Daudé wrote: >>> Hi Jan, >>> >>> On 06/12/2018 02:22 PM, Jan Kiszka wrote: On 2018-05-22 09:00, Jan Kiszka wrote: > On 2018-04-16 17:29, Peter Maydell wro

Re: [Qemu-devel] [PATCH] e1000e: Do not auto-clear ICR bits which aren't set in EIAC

2018-06-12 Thread Philippe Mathieu-Daudé
On 06/12/2018 03:30 PM, Jan Kiszka wrote: > On 2018-06-12 20:11, Philippe Mathieu-Daudé wrote: >> Hi Jan, >> >> On 06/12/2018 02:22 PM, Jan Kiszka wrote: >>> On 2018-05-22 09:00, Jan Kiszka wrote: On 2018-04-16 17:29, Peter Maydell wrote: > On 16 April 2018 at 16:25, Jan Kiszka wrote: >>>

Re: [Qemu-devel] [PATCH] e1000e: Do not auto-clear ICR bits which aren't set in EIAC

2018-06-12 Thread Jan Kiszka
On 2018-06-12 20:11, Philippe Mathieu-Daudé wrote: > Hi Jan, > > On 06/12/2018 02:22 PM, Jan Kiszka wrote: >> On 2018-05-22 09:00, Jan Kiszka wrote: >>> On 2018-04-16 17:29, Peter Maydell wrote: On 16 April 2018 at 16:25, Jan Kiszka wrote: > On 2018-04-01 23:17, Jan Kiszka wrote: >>

Re: [Qemu-devel] [PATCH] e1000e: Do not auto-clear ICR bits which aren't set in EIAC

2018-06-12 Thread Philippe Mathieu-Daudé
Hi Jan, On 06/12/2018 02:22 PM, Jan Kiszka wrote: > On 2018-05-22 09:00, Jan Kiszka wrote: >> On 2018-04-16 17:29, Peter Maydell wrote: >>> On 16 April 2018 at 16:25, Jan Kiszka wrote: On 2018-04-01 23:17, Jan Kiszka wrote: > From: Jan Kiszka > > The spec does not justify cleari

Re: [Qemu-devel] [PATCH] e1000e: Do not auto-clear ICR bits which aren't set in EIAC

2018-06-12 Thread Jan Kiszka
On 2018-05-22 09:00, Jan Kiszka wrote: > On 2018-04-16 17:29, Peter Maydell wrote: >> On 16 April 2018 at 16:25, Jan Kiszka wrote: >>> On 2018-04-01 23:17, Jan Kiszka wrote: From: Jan Kiszka The spec does not justify clearing of any E1000_ICR_OTHER_CAUSES when E1000_ICR_OTHER

Re: [Qemu-devel] [PATCH] e1000e: Do not auto-clear ICR bits which aren't set in EIAC

2018-05-22 Thread Jan Kiszka
On 2018-04-16 17:29, Peter Maydell wrote: > On 16 April 2018 at 16:25, Jan Kiszka wrote: >> On 2018-04-01 23:17, Jan Kiszka wrote: >>> From: Jan Kiszka >>> >>> The spec does not justify clearing of any E1000_ICR_OTHER_CAUSES when >>> E1000_ICR_OTHER is set in EIAC. In fact, removing this code fix

Re: [Qemu-devel] [PATCH] e1000e: Do not auto-clear ICR bits which aren't set in EIAC

2018-04-16 Thread Peter Maydell
On 16 April 2018 at 16:25, Jan Kiszka wrote: > On 2018-04-01 23:17, Jan Kiszka wrote: >> From: Jan Kiszka >> >> The spec does not justify clearing of any E1000_ICR_OTHER_CAUSES when >> E1000_ICR_OTHER is set in EIAC. In fact, removing this code fixes the >> issue the Linux driver runs into since

Re: [Qemu-devel] [PATCH] e1000e: Do not auto-clear ICR bits which aren't set in EIAC

2018-04-16 Thread Jan Kiszka
On 2018-04-01 23:17, Jan Kiszka wrote: > From: Jan Kiszka > > The spec does not justify clearing of any E1000_ICR_OTHER_CAUSES when > E1000_ICR_OTHER is set in EIAC. In fact, removing this code fixes the > issue the Linux driver runs into since 4aea7a5c5e94 ("e1000e: Avoid > receiver overrun inte

Re: [Qemu-devel] [PATCH] e1000e: Do not auto-clear ICR bits which aren't set in EIAC

2018-04-01 Thread no-reply
auto-clear ICR bits which aren't set in EIAC === TEST SCRIPT BEGIN === #!/bin/bash set -e git submodule update --init dtc # Let docker tests dump environment info export SHOW_ENV=1 export J=8 time make docker-test-mingw@fedora === TEST SCRIPT END === Upd

Re: [Qemu-devel] [PATCH] e1000e: Do not auto-clear ICR bits which aren't set in EIAC

2018-04-01 Thread no-reply
not auto-clear ICR bits which aren't set in EIAC === TEST SCRIPT BEGIN === #!/bin/bash set -e git submodule update --init dtc # Let docker tests dump environment info export SHOW_ENV=1 export J=8 time make docker-test-build@min-glib === TEST SCRIPT END === Upd

[Qemu-devel] [PATCH] e1000e: Do not auto-clear ICR bits which aren't set in EIAC

2018-04-01 Thread Jan Kiszka
From: Jan Kiszka The spec does not justify clearing of any E1000_ICR_OTHER_CAUSES when E1000_ICR_OTHER is set in EIAC. In fact, removing this code fixes the issue the Linux driver runs into since 4aea7a5c5e94 ("e1000e: Avoid receiver overrun interrupt bursts") and was worked around by 745d0bd3af9