Re: [Qemu-devel] [PATCH] e1000: document ICS read behaviour

2013-01-11 Thread Stefan Hajnoczi
On Thu, Jan 10, 2013 at 02:03:39PM +0200, Michael S. Tsirkin wrote: > Add code comment to clarify the reason we set ICS with ICR: > the reason was previously undocumented and git > log (commit b1332393cdd7d023de8f1f8aa136ee7866a18968) > confused rather than clarified the comments. > Digging in the

Re: [Qemu-devel] [PATCH] e1000: document ICS read behaviour

2013-01-10 Thread Michael S. Tsirkin
On Thu, Jan 10, 2013 at 02:03:39PM +0200, Michael S. Tsirkin wrote: > Add code comment to clarify the reason we set ICS with ICR: > the reason was previously undocumented and git > log (commit b1332393cdd7d023de8f1f8aa136ee7866a18968) > confused rather than clarified the comments. > Digging in the

[Qemu-devel] [PATCH] e1000: document ICS read behaviour

2013-01-10 Thread Michael S. Tsirkin
Add code comment to clarify the reason we set ICS with ICR: the reason was previously undocumented and git log (commit b1332393cdd7d023de8f1f8aa136ee7866a18968) confused rather than clarified the comments. Digging in the mailing list archives gives the real reason https://lists.gnu.org/archive/html

Re: [Qemu-devel] [PATCH] e1000: document ICS read behaviour

2013-01-10 Thread Stefan Hajnoczi
On Thu, Jan 10, 2013 at 12:17:14PM +0200, Michael S. Tsirkin wrote: > On Thu, Jan 10, 2013 at 09:26:47AM +0100, Stefan Hajnoczi wrote: > > On Thu, Jan 10, 2013 at 12:01:22AM +0200, Michael S. Tsirkin wrote: > > > Add code comment to clarify the reason we set ICS with ICR: > > > the reason was previ

Re: [Qemu-devel] [PATCH] e1000: document ICS read behaviour

2013-01-10 Thread Michael S. Tsirkin
On Thu, Jan 10, 2013 at 09:26:47AM +0100, Stefan Hajnoczi wrote: > On Thu, Jan 10, 2013 at 12:01:22AM +0200, Michael S. Tsirkin wrote: > > Add code comment to clarify the reason we set ICS with ICR: > > the reason was previously undocumented and git > > log (commit b1332393cdd7d023de8f1f8aa136ee786

Re: [Qemu-devel] [PATCH] e1000: document ICS read behaviour

2013-01-10 Thread Stefan Hajnoczi
On Thu, Jan 10, 2013 at 12:01:22AM +0200, Michael S. Tsirkin wrote: > Add code comment to clarify the reason we set ICS with ICR: > the reason was previously undocumented and git > log (commit b1332393cdd7d023de8f1f8aa136ee7866a18968) > confused rather than clarified the comments. > Digging in the

[Qemu-devel] [PATCH] e1000: document ICS read behaviour

2013-01-09 Thread Michael S. Tsirkin
Add code comment to clarify the reason we set ICS with ICR: the reason was previously undocumented and git log (commit b1332393cdd7d023de8f1f8aa136ee7866a18968) confused rather than clarified the comments. Digging in the mailing list archives gives the real reason https://lists.gnu.org/archive/html