Re: [Qemu-devel] [PATCH] e1000: add the ability to select among several specific types of e1000, plus some pointers to documentations and details.

2014-02-27 Thread Stefan Hajnoczi
On Tue, Feb 25, 2014 at 10:24:30AM +0100, Romain Dolbeau wrote: > 2014-02-25 9:58 GMT+01:00 Romain Dolbeau : > > > 2014-02-25 9:01 GMT+01:00 Andreas Färber : > > > > > @@ -1572,6 +1572,9 @@ static const char * const pci_nic_models[] = { > >> > @@ -1584,6 +1587,9 @@ static const char * const pci_ni

Re: [Qemu-devel] [PATCH] e1000: add the ability to select among several specific types of e1000, plus some pointers to documentations and details.

2014-02-25 Thread Romain Dolbeau
2014-02-25 9:58 GMT+01:00 Romain Dolbeau : > 2014-02-25 9:01 GMT+01:00 Andreas Färber : > > > @@ -1572,6 +1572,9 @@ static const char * const pci_nic_models[] = { >> > @@ -1584,6 +1587,9 @@ static const char * const pci_nic_names[] = { >> >> I would hope that adding to these two legacy lists is no

Re: [Qemu-devel] [PATCH] e1000: add the ability to select among several specific types of e1000, plus some pointers to documentations and details.

2014-02-25 Thread Romain Dolbeau
2014-02-25 9:01 GMT+01:00 Andreas Färber : > > -#define E1000(obj) \ > > -OBJECT_CHECK(E1000State, (obj), TYPE_E1000) > > +#define E1000(obj) \ > > + DO_UPCAST(E1000State, parent_obj, obj) > > No, don't go backwards in time please. Take a look at e.g. eepro100, >

Re: [Qemu-devel] [PATCH] e1000: add the ability to select among several specific types of e1000, plus some pointers to documentations and details.

2014-02-25 Thread Andreas Färber
Hi, Am 24.02.2014 20:08, schrieb Romain Dolbeau: > Hello, > > This patch adds this ability to select a specific variant of > the e1000 virtual ethernet from the command-line. Previously > only a single device was available, selected at compile time. > This helps for guests with limited hardware s

Re: [Qemu-devel] [PATCH] e1000: add the ability to select among

2014-02-24 Thread Gabriel L. Somlo
On Mon, 24 Feb 2014 15:08:17 -0500 Romain Dolbeau wrote: > This patch adds this ability to select a specific variant of > the e1000 virtual ethernet from the command-line. Previously > only a single device was available, selected at compile time. > This helps for guests with limited hardware suppo

[Qemu-devel] [PATCH] e1000: add the ability to select among several specific types of e1000, plus some pointers to documentations and details.

2014-02-24 Thread Romain Dolbeau
Hello, This patch adds this ability to select a specific variant of the e1000 virtual ethernet from the command-line. Previously only a single device was available, selected at compile time. This helps for guests with limited hardware support, as with this patch not all guests are required to use