On 9 August 2011 15:10, Anthony PERARD wrote:
> On Fri, Aug 5, 2011 at 17:53, Anthony Liguori wrote:
>>
>> You'll break some GCCs with -Wall -Werror with this. Please do:
>>
>> if ((val & E1000_CTRL_RST)) {
>
> :(, I never heard of this. But OK, I will do that.
Please don't unless Anthony L can
On Fri, Aug 5, 2011 at 17:53, Anthony Liguori wrote:
>
> You'll break some GCCs with -Wall -Werror with this. Please do:
>
> if ((val & E1000_CTRL_RST)) {
:(, I never heard of this. But OK, I will do that.
--
Anthony PERARD
On 5 August 2011 17:53, Anthony Liguori wrote:
> You'll break some GCCs with -Wall -Werror with this. Please do:
>
> if ((val & E1000_CTRL_RST)) {
Hmm? There's lots of examples of that in the codebase:
$ git grep 'if ([a-zA-Z]* & ' | wc -l
1558
'=' (assignment) needs those extra braces, but log
On 08/05/2011 09:53 AM, Anthony Liguori wrote:
>> +if (val& E1000_CTRL_RST) {
>
> You'll break some GCCs with -Wall -Werror with this. Please do:
>
> if ((val & E1000_CTRL_RST)) {
Err, really? What versions?
I don't recall that ever being true.
r~
On 08/05/2011 09:36 AM, Anthony PERARD wrote:
Signed-off-by: Anthony PERARD
---
hw/e1000.c | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/hw/e1000.c b/hw/e1000.c
index 96d84f9..a1388e9 100644
--- a/hw/e1000.c
+++ b/hw/e1000.c
@@ -150,6 +150,8 @@ static const
Signed-off-by: Anthony PERARD
---
hw/e1000.c | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/hw/e1000.c b/hw/e1000.c
index 96d84f9..a1388e9 100644
--- a/hw/e1000.c
+++ b/hw/e1000.c
@@ -150,6 +150,8 @@ static const char phy_regcap[0x20] = {
[PHY_ID2] = PHY_R,
