Re: [Qemu-devel] [PATCH] e1000/rtl8139: forbid dealing with packets when VM is paused

2014-05-27 Thread Stefan Hajnoczi
On Mon, May 26, 2014 at 02:51:48PM +0300, Michael S. Tsirkin wrote: > On Mon, May 26, 2014 at 01:48:13PM +0200, Stefan Hajnoczi wrote: > > On Wed, May 14, 2014 at 03:46:48PM +0300, Michael S. Tsirkin wrote: > > > On Wed, May 14, 2014 at 02:30:26PM +0200, Stefan Hajnoczi wrote: > > > > On Thu, May 0

Re: [Qemu-devel] [PATCH] e1000/rtl8139: forbid dealing with packets when VM is paused

2014-05-26 Thread Michael S. Tsirkin
On Mon, May 26, 2014 at 01:48:13PM +0200, Stefan Hajnoczi wrote: > On Wed, May 14, 2014 at 03:46:48PM +0300, Michael S. Tsirkin wrote: > > On Wed, May 14, 2014 at 02:30:26PM +0200, Stefan Hajnoczi wrote: > > > On Thu, May 08, 2014 at 12:51:05PM +, Zhanghailiang wrote: > > > > > If you implement

Re: [Qemu-devel] [PATCH] e1000/rtl8139: forbid dealing with packets when VM is paused

2014-05-26 Thread Stefan Hajnoczi
On Wed, May 14, 2014 at 03:46:48PM +0300, Michael S. Tsirkin wrote: > On Wed, May 14, 2014 at 02:30:26PM +0200, Stefan Hajnoczi wrote: > > On Thu, May 08, 2014 at 12:51:05PM +, Zhanghailiang wrote: > > > > If you implement this in the net layer then that problem is easy to > > > > resolve sinc

Re: [Qemu-devel] [PATCH] e1000/rtl8139: forbid dealing with packets when VM is paused

2014-05-14 Thread Michael S. Tsirkin
On Wed, May 14, 2014 at 02:30:26PM +0200, Stefan Hajnoczi wrote: > On Thu, May 08, 2014 at 12:51:05PM +, Zhanghailiang wrote: > > > If you implement this in the net layer then that problem is easy to > > > resolve since > > > we can flush all queues when the guest resumes to get packets flowin

Re: [Qemu-devel] [PATCH] e1000/rtl8139: forbid dealing with packets when VM is paused

2014-05-14 Thread Stefan Hajnoczi
On Thu, May 08, 2014 at 12:51:05PM +, Zhanghailiang wrote: > > If you implement this in the net layer then that problem is easy to resolve > > since > > we can flush all queues when the guest resumes to get packets flowing again. > > > Do you mean we should also listen for VM runstate changes

Re: [Qemu-devel] [PATCH] e1000/rtl8139: forbid dealing with packets when VM is paused

2014-05-08 Thread Zhanghailiang
Hi Stefan, I have test other network cards, such as pcnet, ne2000, and they also have the problem. > On Mon, Apr 28, 2014 at 03:22:34AM +, Zhanghailiang wrote: > > > On Sat, Apr 26, 2014 at 9:04 PM, Peter Maydell > > > > > > wrote: > > > > On 26 April 2014 11:44, Amos Kong wrote: > > > >> >

Re: [Qemu-devel] [PATCH] e1000/rtl8139: forbid dealing with packets when VM is paused

2014-05-06 Thread Stefan Hajnoczi
On Mon, Apr 28, 2014 at 03:22:34AM +, Zhanghailiang wrote: > > On Sat, Apr 26, 2014 at 9:04 PM, Peter Maydell > > wrote: > > > On 26 April 2014 11:44, Amos Kong wrote: > > >> > > >> I'm ok with the patch idea. > > >> > > >> On Sat, Apr 26, 2014 at 06:19:12PM +0800, zhanghailiang wrote: > > >>

Re: [Qemu-devel] [PATCH] e1000/rtl8139: forbid dealing with packets when VM is paused

2014-04-27 Thread Zhanghailiang
> On Sat, Apr 26, 2014 at 9:04 PM, Peter Maydell > wrote: > > On 26 April 2014 11:44, Amos Kong wrote: > >> > >> I'm ok with the patch idea. > >> > >> On Sat, Apr 26, 2014 at 06:19:12PM +0800, zhanghailiang wrote: > >>> For e1000/rtl8139, qemu can still send/receive packets when VM is > paused. >

Re: [Qemu-devel] [PATCH] e1000/rtl8139: forbid dealing with packets when VM is paused

2014-04-27 Thread Zhanghailiang
Hi Amos: Thanks for replying. > I'm ok with the patch idea. > > On Sat, Apr 26, 2014 at 06:19:12PM +0800, zhanghailiang wrote: > > For e1000/rtl8139, qemu can still send/receive packets when VM is paused. > > ^ >-> > isn't runni

Re: [Qemu-devel] [PATCH] e1000/rtl8139: forbid dealing with packets when VM is paused

2014-04-26 Thread Peter Crosthwaite
On Sat, Apr 26, 2014 at 9:04 PM, Peter Maydell wrote: > On 26 April 2014 11:44, Amos Kong wrote: >> >> I'm ok with the patch idea. >> >> On Sat, Apr 26, 2014 at 06:19:12PM +0800, zhanghailiang wrote: >>> For e1000/rtl8139, qemu can still send/receive packets when VM is paused. >>

Re: [Qemu-devel] [PATCH] e1000/rtl8139: forbid dealing with packets when VM is paused

2014-04-26 Thread Peter Maydell
On 26 April 2014 11:44, Amos Kong wrote: > > I'm ok with the patch idea. > > On Sat, Apr 26, 2014 at 06:19:12PM +0800, zhanghailiang wrote: >> For e1000/rtl8139, qemu can still send/receive packets when VM is paused. > ^ >

Re: [Qemu-devel] [PATCH] e1000/rtl8139: forbid dealing with packets when VM is paused

2014-04-26 Thread Amos Kong
I'm ok with the patch idea. On Sat, Apr 26, 2014 at 06:19:12PM +0800, zhanghailiang wrote: > For e1000/rtl8139, qemu can still send/receive packets when VM is paused. ^

[Qemu-devel] [PATCH] e1000/rtl8139: forbid dealing with packets when VM is paused

2014-04-26 Thread zhanghailiang
For e1000/rtl8139, qemu can still send/receive packets when VM is paused. If this happened in *migration's* last PAUSE VM stage, the new dirty RAM related to the packets will be missed. To avoid this, do things like virtio-net, forbid sending/receiving packets when VM is suspend. Signed-off-by: