Re: [Qemu-devel] [PATCH] drive-mirror: fix memory leak

2014-01-21 Thread Zhang Min
Hi,Fam I am very sorry for this patch,because I use Outlook to send this email. Later on, I will submit the patch by git send-email again. On 2014/1/22 11:41, Fam Zheng wrote: > Hi, > > The patch itself looks good to me, but it has too many extra empty lines > interleaved. Please try to use "git

Re: [Qemu-devel] [PATCH] drive-mirror: fix memory leak

2014-01-21 Thread Fam Zheng
Hi, The patch itself looks good to me, but it has too many extra empty lines interleaved. Please try to use "git send-email" to submit your patches, for more information, follow the instructions as in: http://wiki.qemu.org/Contribute/SubmitAPatch On Tue, 01/21 11:43, Chentao (Boby) wrote: > In t

[Qemu-devel] [PATCH] drive-mirror: fix memory leak

2014-01-21 Thread Chentao (Boby)
In the function mirror_iteration() -> qemu_iovec_init(), it alloc memory for op->qiov.iov, when the write request call back, but in the function mirror_iteration_done(), it only free the op, not free the op->qiov.iov, so this cause memory leak. Signed-off-by: Zhang Min mailto:rudy.zhang...