On 05/18/2018 03:34 AM, Peter Maydell wrote:
> On 15 May 2018 at 15:46, Richard Henderson wrote:
>> On 05/15/2018 06:25 AM, Peter Maydell wrote:
>>> That said, I think we're planning to deprecate vixl now we have the
>>> capstone support. Richard, what's the status here? Could we just remove
>>> t
On 15 May 2018 at 15:46, Richard Henderson wrote:
> On 05/15/2018 06:25 AM, Peter Maydell wrote:
>> That said, I think we're planning to deprecate vixl now we have the
>> capstone support. Richard, what's the status here? Could we just remove
>> the vixl code now?
>
> We could just remove vixl, ye
On 15 May 2018 at 14:13, Stefan Weil wrote:
> That fix will work for the moment, but is not sufficient for the future
> because it only supports gcc 7.x, but not gcc 8.x or later:
>
> +#elif __GNUC__ == 7
Fix to make that use >= is currently going through upstream vixl
code review: https://review
On 05/15/2018 06:25 AM, Peter Maydell wrote:
> On 15 May 2018 at 14:13, Stefan Weil wrote:
>> This is fixed in upstream vixl, in fact:
>>
>> https://git.linaro.org/arm/vixl.git/commit/?id=de326f850f736c3a337fda52845ed3d2e620cc02
>>
>> That fix will work for the moment, but is not sufficient for th
On 15 May 2018 at 15:46, Richard Henderson wrote:
> On 05/15/2018 06:25 AM, Peter Maydell wrote:
>> I guess that having the compiler check is better than finding them
>> later with coverity. It's a shame gcc doesn't support the standard
>> mechanism of using /* fallthrough */ to mark these, though
On 15 May 2018 at 14:13, Stefan Weil wrote:
> This is fixed in upstream vixl, in fact:
>
> https://git.linaro.org/arm/vixl.git/commit/?id=de326f850f736c3a337fda52845ed3d2e620cc02
>
> That fix will work for the moment, but is not sufficient for the future
> because it only supports gcc 7.x, but not
Am 15.05.2018 um 14:13 schrieb Peter Maydell:
> On 13 May 2018 at 10:57, Stefan Weil wrote:
>> Even with the above patch, disas/libvixl raises a compiler warning for a
>> fall through case. The patch below fixes that warning, but I am not sure
>> whether a fall through is correct there.
>>
>> Stef
On 13 May 2018 at 10:57, Stefan Weil wrote:
> Even with the above patch, disas/libvixl raises a compiler warning for a
> fall through case. The patch below fixes that warning, but I am not sure
> whether a fall through is correct there.
>
> Stefan
>
>
> diff --git a/disas/libvixl/vixl/a64/disasm-a
On 13 May 2018 at 10:57, Stefan Weil wrote:
> Am 13.05.2018 um 11:06 schrieb Stefan Weil:
>> It now prevents compiler warnings (enabled with -Wimplicit-fallthrough=
>> or -Wextra) as intended.
>>
>> Signed-off-by: Stefan Weil
>> ---
>>
>> I suggest to add and use a similar macro QEMU_FALLTHROUGH(
Am 13.05.2018 um 11:06 schrieb Stefan Weil:
> It now prevents compiler warnings (enabled with -Wimplicit-fallthrough=
> or -Wextra) as intended.
>
> Signed-off-by: Stefan Weil
> ---
>
> I suggest to add and use a similar macro QEMU_FALLTHROUGH()
> for the rest of the code and can provide a patch
It now prevents compiler warnings (enabled with -Wimplicit-fallthrough=
or -Wextra) as intended.
Signed-off-by: Stefan Weil
---
I suggest to add and use a similar macro QEMU_FALLTHROUGH()
for the rest of the code and can provide a patch if that's
fine for everyone.
Regards
Stefan
disas/libvix
11 matches
Mail list logo
