Re: [Qemu-devel] [PATCH] disas/i386.c: Add explicit braces round empty for-loop body

2013-02-23 Thread Blue Swirl
Thanks, applied. On Sat, Feb 2, 2013 at 5:17 PM, Peter Maydell wrote: > Add explicit braces round an empty for-loop body; this fits > QEMU style and is easier to read than an inconspicuous semicolon > at the end of the line. It also silences a clang warning: > > disas/i386.c:4723:49: warning: for

Re: [Qemu-devel] [PATCH] disas/i386.c: Add explicit braces round empty for-loop body

2013-02-18 Thread Peter Maydell
Post-unfreeze ping for trivial... ( patchwork url: http://patchwork.ozlabs.org/patch/217696/ ) thanks -- PMM On 2 February 2013 17:17, Peter Maydell wrote: > Add explicit braces round an empty for-loop body; this fits > QEMU style and is easier to read than an inconspicuous semicolon > at the en

Re: [Qemu-devel] [PATCH] disas/i386.c: Add explicit braces round empty for-loop body

2013-02-02 Thread Peter Maydell
On 2 February 2013 18:34, Andreas Färber wrote: > Am 02.02.2013 18:17, schrieb Peter Maydell: >> This is the only clang warning on MacOSX apart from the ones about >> deprecated features in audio/coreaudio.c and ui/cocoa.m > On v10.5.8 I'm seeing some redundant declaration warnings from > disas/s

Re: [Qemu-devel] [PATCH] disas/i386.c: Add explicit braces round empty for-loop body

2013-02-02 Thread Andreas Färber
Am 02.02.2013 18:17, schrieb Peter Maydell: > Add explicit braces round an empty for-loop body; this fits > QEMU style and is easier to read than an inconspicuous semicolon > at the end of the line. It also silences a clang warning: > > disas/i386.c:4723:49: warning: for loop has empty body [-Wemp

[Qemu-devel] [PATCH] disas/i386.c: Add explicit braces round empty for-loop body

2013-02-02 Thread Peter Maydell
Add explicit braces round an empty for-loop body; this fits QEMU style and is easier to read than an inconspicuous semicolon at the end of the line. It also silences a clang warning: disas/i386.c:4723:49: warning: for loop has empty body [-Wempty-body] for (i = 0; tmp[i] == '0' && tmp[i