Re: [Qemu-devel] [PATCH] darwin-user: Remove unneeded null pointer check

2011-04-27 Thread Aurelien Jarno
On Sun, Apr 03, 2011 at 06:22:45PM +0200, Stefan Weil wrote: > cppcheck reports this error: > > commpage.c:223: error: Possible null pointer dereference: > value - otherwise it is redundant to check if value is null at line 214 > > The null pointer check in line 214 is indeed not needed. > If val

[Qemu-devel] [PATCH] darwin-user: Remove unneeded null pointer check

2011-04-03 Thread Stefan Weil
cppcheck reports this error: commpage.c:223: error: Possible null pointer dereference: value - otherwise it is redundant to check if value is null at line 214 The null pointer check in line 214 is indeed not needed. If value were null, the code would crash in line 223. See do_compare_and_swap64 w