Re: [Qemu-devel] [PATCH] curses: build with -std=gnu99

2016-10-28 Thread Gerd Hoffmann
Hi, > Before we uglify our code to work around (egregious!) defects in certain > compilers, we should find out whether and where exactly these defects > exist, and whether it's worth targeting the defective compilers. Using iconv is on the table _anyway_, to properly support "-display curses,ch

Re: [Qemu-devel] [PATCH] curses: build with -std=gnu99

2016-10-28 Thread Markus Armbruster
Samuel Thibault writes: > Markus Armbruster, on Fri 28 Oct 2016 08:51:20 +0200, wrote: >> Samuel Thibault writes: >> >> > Peter Maydell, on Thu 27 Oct 2016 17:52:17 +0100, wrote: >> >> http://www.thecodingforums.com/threads/wchar_t-is-useless.806149/#post-4398211 >> > >> > UURrgll... So we can'

Re: [Qemu-devel] [PATCH] curses: build with -std=gnu99

2016-10-28 Thread Samuel Thibault
Markus Armbruster, on Fri 28 Oct 2016 08:51:20 +0200, wrote: > Samuel Thibault writes: > > > Peter Maydell, on Thu 27 Oct 2016 17:52:17 +0100, wrote: > >> http://www.thecodingforums.com/threads/wchar_t-is-useless.806149/#post-4398211 > > > > UURrgll... So we can't use L'\u23bd' on such systems, i

Re: [Qemu-devel] [PATCH] curses: build with -std=gnu99

2016-10-27 Thread Markus Armbruster
Samuel Thibault writes: > Peter Maydell, on Thu 27 Oct 2016 17:52:17 +0100, wrote: >> On 27 October 2016 at 17:36, Samuel Thibault wrote: >> > Peter Maydell, on Thu 27 Oct 2016 17:14:52 +0100, wrote: >> >> On 27 October 2016 at 16:58, Samuel Thibault >> >> wrote: >> >> > Gerd Hoffmann, on Thu

Re: [Qemu-devel] [PATCH] curses: build with -std=gnu99

2016-10-27 Thread Samuel Thibault
Peter Maydell, on Thu 27 Oct 2016 17:52:17 +0100, wrote: > On 27 October 2016 at 17:36, Samuel Thibault wrote: > > Peter Maydell, on Thu 27 Oct 2016 17:14:52 +0100, wrote: > >> On 27 October 2016 at 16:58, Samuel Thibault > >> wrote: > >> > Gerd Hoffmann, on Thu 27 Oct 2016 17:55:47 +0200, wrote

Re: [Qemu-devel] [PATCH] curses: build with -std=gnu99

2016-10-27 Thread Samuel Thibault
Peter Maydell, on Thu 27 Oct 2016 17:14:52 +0100, wrote: > On 27 October 2016 at 16:58, Samuel Thibault wrote: > > Gerd Hoffmann, on Thu 27 Oct 2016 17:55:47 +0200, wrote: > >> /home/kraxel/projects/qemu/ui/curses.c:627:18: error: universal > >> character names are only valid in C++ and C99 [-Werr

Re: [Qemu-devel] [PATCH] curses: build with -std=gnu99

2016-10-27 Thread Peter Maydell
On 27 October 2016 at 16:58, Samuel Thibault wrote: > Gerd Hoffmann, on Thu 27 Oct 2016 17:55:47 +0200, wrote: >> /home/kraxel/projects/qemu/ui/curses.c:627:18: error: universal >> character names are only valid in C++ and C99 [-Werror] >> case L'\u23bd': > > Another way could be to a

Re: [Qemu-devel] [PATCH] curses: build with -std=gnu99

2016-10-27 Thread Peter Maydell
On 27 October 2016 at 17:36, Samuel Thibault wrote: > Peter Maydell, on Thu 27 Oct 2016 17:14:52 +0100, wrote: >> On 27 October 2016 at 16:58, Samuel Thibault wrote: >> > Gerd Hoffmann, on Thu 27 Oct 2016 17:55:47 +0200, wrote: >> >> /home/kraxel/projects/qemu/ui/curses.c:627:18: error: universal

Re: [Qemu-devel] [PATCH] curses: build with -std=gnu99

2016-10-27 Thread Samuel Thibault
Gerd Hoffmann, on Thu 27 Oct 2016 17:55:47 +0200, wrote: > /home/kraxel/projects/qemu/ui/curses.c:627:18: error: universal > character names are only valid in C++ and C99 [-Werror] > case L'\u23bd': Another way could be to assume unicode encoding of wchar_t characters (which looks ver

Re: [Qemu-devel] [PATCH] curses: build with -std=gnu99

2016-10-27 Thread Gerd Hoffmann
Hi, > > +# needed to make gcc accept wide unicode chars without warning > > +curses.o-cflags := -std=gnu99 > > + > > ifeq ($(CONFIG_SDLABI),1.2) > > sdl.mo-objs := sdl.o sdl_zoom.o > > endif > > -- > > 1.8.3.1 > > I'm not sure about this. > > Do we really want gnu99 and not c99? Should we j

Re: [Qemu-devel] [PATCH] curses: build with -std=gnu99

2016-10-27 Thread G 3
On Oct 27, 2016, at 11:07 AM, Gerd Hoffmann wrote: +# needed to make gcc accept wide unicode chars without warning +curses.o-cflags := -std=gnu99 Could we add a commit message to this patch? It could answer questions like: Why this patch is needed? Who needs this patch? What problem it solv

Re: [Qemu-devel] [PATCH] curses: build with -std=gnu99

2016-10-27 Thread Gerd Hoffmann
> > +# needed to make gcc accept wide unicode chars without warning > > +curses.o-cflags := -std=gnu99 > Could we add a commit message to this patch? It could answer > questions like: > > Why this patch is needed? > Who needs this patch? > What problem it solves. The comment added by the patch

Re: [Qemu-devel] [PATCH] curses: build with -std=gnu99

2016-10-27 Thread Peter Maydell
On 27 October 2016 at 12:46, Gerd Hoffmann wrote: > --- > ui/Makefile.objs | 3 +++ > 1 file changed, 3 insertions(+) Missing commit message and signed-off-by line... > diff --git a/ui/Makefile.objs b/ui/Makefile.objs > index dc936f1..62f4cf3 100644 > --- a/ui/Makefile.objs > +++ b/ui/Makefile.

[Qemu-devel] [PATCH] curses: build with -std=gnu99

2016-10-27 Thread G 3
On Oct 27, 2016, at 8:04 AM, qemu-devel-requ...@nongnu.org wrote: --- ui/Makefile.objs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ui/Makefile.objs b/ui/Makefile.objs index dc936f1..62f4cf3 100644 --- a/ui/Makefile.objs +++ b/ui/Makefile.objs @@ -17,6 +17,9 @@ common-obj-$(CONFIG_CU

[Qemu-devel] [PATCH] curses: build with -std=gnu99

2016-10-27 Thread Gerd Hoffmann
--- ui/Makefile.objs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ui/Makefile.objs b/ui/Makefile.objs index dc936f1..62f4cf3 100644 --- a/ui/Makefile.objs +++ b/ui/Makefile.objs @@ -17,6 +17,9 @@ common-obj-$(CONFIG_CURSES) += curses.o common-obj-$(CONFIG_VNC) += $(vnc-obj-y) common-ob