Re: [Qemu-devel] [PATCH] curl: Don't deref NULL pointer in call to aio_poll.

2014-08-27 Thread Fam Zheng
On Wed, 08/27 18:31, Richard W.M. Jones wrote: > Signed-off-by: Richard W.M. Jones It would be better to add the cover letter explanation as the commit message of the patch too. > --- > block/curl.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/block/curl.c b

Re: [Qemu-devel] [PATCH] curl: Don't deref NULL pointer in call to aio_poll.

2014-08-27 Thread Paolo Bonzini
Il 27/08/2014 19:31, Richard W.M. Jones ha scritto: > Signed-off-by: Richard W.M. Jones > --- > block/curl.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/block/curl.c b/block/curl.c > index 46f1082..8b69f28 100644 > --- a/block/curl.c > +++ b/block/curl.c > @@

[Qemu-devel] [PATCH] curl: Don't deref NULL pointer in call to aio_poll.

2014-08-27 Thread Richard W.M. Jones
The original code in block/curl.c dereferences state *after* checking that it is NULL. That's obviously wrong, and indeed I can easily provoke a segfault when talking to a VMware vCenter server. I'm not as sure that this fix is the correct one, so please review it carefully. However it does at l

[Qemu-devel] [PATCH] curl: Don't deref NULL pointer in call to aio_poll.

2014-08-27 Thread Richard W.M. Jones
Signed-off-by: Richard W.M. Jones --- block/curl.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/curl.c b/block/curl.c index 46f1082..8b69f28 100644 --- a/block/curl.c +++ b/block/curl.c @@ -355,7 +355,7 @@ static void curl_multi_timeout_do(void *arg) #endif