Re: [Qemu-devel] [PATCH] cryptodev: fix asserting single queue

2017-03-22 Thread Gonglei (Arei)
> > > On 03/22/2017 01:36 PM, Halil Pasic wrote: > > We already check for queues == 1 in cryptodev_builtin_init and when that > > is not true raise an error. But before that error is reported the > > assertion in cryptodev_builtin_cleanup kicks in (because object is being > > finalized and freed)

Re: [Qemu-devel] [PATCH] cryptodev: fix asserting single queue

2017-03-22 Thread Eric Blake
On 03/22/2017 09:56 AM, Halil Pasic wrote: > > > On 03/22/2017 01:36 PM, Halil Pasic wrote: >> We already check for queues == 1 in cryptodev_builtin_init and when that >> is not true raise an error. But before that error is reported the >> assertion in cryptodev_builtin_cleanup kicks in (because

Re: [Qemu-devel] [PATCH] cryptodev: fix asserting single queue

2017-03-22 Thread Halil Pasic
On 03/22/2017 01:36 PM, Halil Pasic wrote: > We already check for queues == 1 in cryptodev_builtin_init and when that > is not true raise an error. But before that error is reported the > assertion in cryptodev_builtin_cleanup kicks in (because object is being > finalized and freed). > > Let's r

[Qemu-devel] [PATCH] cryptodev: fix asserting single queue

2017-03-22 Thread Halil Pasic
We already check for queues == 1 in cryptodev_builtin_init and when that is not true raise an error. But before that error is reported the assertion in cryptodev_builtin_cleanup kicks in (because object is being finalized and freed). Let's remove assert(queues == 1) form cryptodev_builtin_cleanup