Re: [Qemu-devel] [PATCH] crypto: extend unit tests to cover decryption too

2015-07-20 Thread Eric Blake
On 07/20/2015 03:37 PM, Peter Maydell wrote: > On 20 July 2015 at 21:57, Eric Blake wrote: >> On 07/20/2015 11:28 AM, Daniel P. Berrange wrote: >>> The current unit test only verify the encryption API, which >> >> grammatical mismatch; you want either: >> tests only verify >> test only verifies >>

Re: [Qemu-devel] [PATCH] crypto: extend unit tests to cover decryption too

2015-07-20 Thread Peter Maydell
On 20 July 2015 at 21:57, Eric Blake wrote: > On 07/20/2015 11:28 AM, Daniel P. Berrange wrote: >> The current unit test only verify the encryption API, which > > grammatical mismatch; you want either: > tests only verify > test only verifies > >> resulted in us missing a recently introduced bug i

Re: [Qemu-devel] [PATCH] crypto: extend unit tests to cover decryption too

2015-07-20 Thread Eric Blake
On 07/20/2015 11:28 AM, Daniel P. Berrange wrote: > The current unit test only verify the encryption API, which grammatical mismatch; you want either: tests only verify test only verifies > resulted in us missing a recently introduced bug in the > decryption API from commit d3462e3. It was fortun

[Qemu-devel] [PATCH] crypto: extend unit tests to cover decryption too

2015-07-20 Thread Daniel P. Berrange
The current unit test only verify the encryption API, which resulted in us missing a recently introduced bug in the decryption API from commit d3462e3. It was fortunately later discovered & fixed by commit bd0959 thanks to the QEMU I/O tests for qcow2 encryption, but we should really detect this di