Re: [Qemu-devel] [PATCH] cputlb: Fix regression with TCG interpreter (bug 1310324)

2014-05-28 Thread Paolo Bonzini
Il 28/05/2014 18:43, Peter Maydell ha scritto: On 28 May 2014 17:42, Paolo Bonzini wrote: Peter, I suggest instead that you review/ack patches 2 and 3 of http://thread.gmane.org/gmane.comp.emulators.qemu/274837 and I include this patch in the resulting pull request. "Error GMANE-03252: Someth

Re: [Qemu-devel] [PATCH] cputlb: Fix regression with TCG interpreter (bug 1310324)

2014-05-28 Thread Paolo Bonzini
Il 28/05/2014 18:36, Stefan Weil ha scritto: Am 28.04.2014 20:30, schrieb Richard Henderson: On 04/28/2014 11:24 AM, Andreas Färber wrote: No objections and not too familiar with that part of code myself - suggest you take it through your tcg tree if no one else objects. Ok, will do. r~ P

Re: [Qemu-devel] [PATCH] cputlb: Fix regression with TCG interpreter (bug 1310324)

2014-05-28 Thread Peter Maydell
On 28 May 2014 17:42, Paolo Bonzini wrote: > Peter, I suggest instead that you review/ack patches 2 and 3 of > http://thread.gmane.org/gmane.comp.emulators.qemu/274837 and I include this > patch in the resulting pull request. "Error GMANE-03252: Something is wrong. Perhaps something didn't match

Re: [Qemu-devel] [PATCH] cputlb: Fix regression with TCG interpreter (bug 1310324)

2014-05-28 Thread Stefan Weil
Am 28.04.2014 20:30, schrieb Richard Henderson: > On 04/28/2014 11:24 AM, Andreas Färber wrote: >> No objections and not too familiar with that part of code myself - >> suggest you take it through your tcg tree if no one else objects. > Ok, will do. > > > r~ Ping? Peter, maybe you can apply this

Re: [Qemu-devel] [PATCH] cputlb: Fix regression with TCG interpreter (bug 1310324)

2014-04-28 Thread Richard Henderson
On 04/28/2014 11:24 AM, Andreas Färber wrote: > No objections and not too familiar with that part of code myself - > suggest you take it through your tcg tree if no one else objects. Ok, will do. r~

Re: [Qemu-devel] [PATCH] cputlb: Fix regression with TCG interpreter (bug 1310324)

2014-04-28 Thread Andreas Färber
Am 28.04.2014 19:24, schrieb Richard Henderson: > On 04/28/2014 10:20 AM, Stefan Weil wrote: >> Commit 0f842f8a246f2b5b51a11c13f933bf7a90ae8e96 replaced GETPC_EXT() which >> was derived from GETPC() by GETRA_EXT() without fixing cputlb.c. A later >> patch replaced GETRA_EXT() by GETRA() in exec/sof

Re: [Qemu-devel] [PATCH] cputlb: Fix regression with TCG interpreter (bug 1310324)

2014-04-28 Thread Richard Henderson
On 04/28/2014 10:20 AM, Stefan Weil wrote: > Commit 0f842f8a246f2b5b51a11c13f933bf7a90ae8e96 replaced GETPC_EXT() which > was derived from GETPC() by GETRA_EXT() without fixing cputlb.c. A later > patch replaced GETRA_EXT() by GETRA() in exec/softmmu_template.h which > is included in cputlb.c. > >

[Qemu-devel] [PATCH] cputlb: Fix regression with TCG interpreter (bug 1310324)

2014-04-28 Thread Stefan Weil
Commit 0f842f8a246f2b5b51a11c13f933bf7a90ae8e96 replaced GETPC_EXT() which was derived from GETPC() by GETRA_EXT() without fixing cputlb.c. A later patch replaced GETRA_EXT() by GETRA() in exec/softmmu_template.h which is included in cputlb.c. The TCG interpreter failed because the values returned