Re: [Qemu-devel] [PATCH] cpus: reset throttle_thread_scheduled after sleep

2017-06-07 Thread Paolo Bonzini
On 07/06/2017 18:26, Juan Quintela wrote: > Felipe Franciosi wrote: >> Currently, the throttle_thread_scheduled flag is reset back to 0 before >> sleeping (as part of the throttling logic). Given that throttle_timer >> (well, any timer) may tick with a slight delay, it so happens that under >> h

Re: [Qemu-devel] [PATCH] cpus: reset throttle_thread_scheduled after sleep

2017-06-07 Thread Juan Quintela
Felipe Franciosi wrote: > Currently, the throttle_thread_scheduled flag is reset back to 0 before > sleeping (as part of the throttling logic). Given that throttle_timer > (well, any timer) may tick with a slight delay, it so happens that under > heavy throttling (ie. close or on CPU_THROTTLE_PCT_

Re: [Qemu-devel] [PATCH] cpus: reset throttle_thread_scheduled after sleep

2017-06-01 Thread Dr. David Alan Gilbert
* Felipe Franciosi (fel...@nutanix.com) wrote: > > > On 1 Jun 2017, at 15:36, Dr. David Alan Gilbert wrote: > > > > * Jason J. Herne (jjhe...@linux.vnet.ibm.com) wrote: > >> On 05/19/2017 05:29 PM, Felipe Franciosi wrote: > >>> Currently, the throttle_thread_scheduled flag is reset back to 0 bef

Re: [Qemu-devel] [PATCH] cpus: reset throttle_thread_scheduled after sleep

2017-06-01 Thread Felipe Franciosi
> On 1 Jun 2017, at 15:36, Dr. David Alan Gilbert wrote: > > * Jason J. Herne (jjhe...@linux.vnet.ibm.com) wrote: >> On 05/19/2017 05:29 PM, Felipe Franciosi wrote: >>> Currently, the throttle_thread_scheduled flag is reset back to 0 before >>> sleeping (as part of the throttling logic). Given t

Re: [Qemu-devel] [PATCH] cpus: reset throttle_thread_scheduled after sleep

2017-06-01 Thread Dr. David Alan Gilbert
* Jason J. Herne (jjhe...@linux.vnet.ibm.com) wrote: > On 05/19/2017 05:29 PM, Felipe Franciosi wrote: > > Currently, the throttle_thread_scheduled flag is reset back to 0 before > > sleeping (as part of the throttling logic). Given that throttle_timer > > (well, any timer) may tick with a slight d

Re: [Qemu-devel] [PATCH] cpus: reset throttle_thread_scheduled after sleep

2017-05-25 Thread Paolo Bonzini
On 25/05/2017 18:25, Felipe Franciosi wrote: > The perfect solution (for this throttling strategy) would probably be > a per-cpu timer. In the meantime, I think avoiding massive sleeps is > a win. We observed stalls in excess of 70 secs at 99% throttle. Ah, so the issue is not overcommit, it's t

Re: [Qemu-devel] [PATCH] cpus: reset throttle_thread_scheduled after sleep

2017-05-25 Thread Felipe Franciosi
> On 25 May 2017, at 16:52, Paolo Bonzini wrote: > > > > On 19/05/2017 23:29, Felipe Franciosi wrote: >> Currently, the throttle_thread_scheduled flag is reset back to 0 before >> sleeping (as part of the throttling logic). Given that throttle_timer >> (well, any timer) may tick with a slight

Re: [Qemu-devel] [PATCH] cpus: reset throttle_thread_scheduled after sleep

2017-05-25 Thread Paolo Bonzini
On 19/05/2017 23:29, Felipe Franciosi wrote: > Currently, the throttle_thread_scheduled flag is reset back to 0 before > sleeping (as part of the throttling logic). Given that throttle_timer > (well, any timer) may tick with a slight delay, it so happens that under > heavy throttling (ie. close o

Re: [Qemu-devel] [PATCH] cpus: reset throttle_thread_scheduled after sleep

2017-05-22 Thread Jason J. Herne
On 05/19/2017 05:29 PM, Felipe Franciosi wrote: Currently, the throttle_thread_scheduled flag is reset back to 0 before sleeping (as part of the throttling logic). Given that throttle_timer (well, any timer) may tick with a slight delay, it so happens that under heavy throttling (ie. close or on

[Qemu-devel] [PATCH] cpus: reset throttle_thread_scheduled after sleep

2017-05-19 Thread Felipe Franciosi
Currently, the throttle_thread_scheduled flag is reset back to 0 before sleeping (as part of the throttling logic). Given that throttle_timer (well, any timer) may tick with a slight delay, it so happens that under heavy throttling (ie. close or on CPU_THROTTLE_PCT_MAX) the tick may schedule a furt