Re: [Qemu-devel] [PATCH] cpu_defs: Simplify CPUTLB padding logic

2015-07-06 Thread Peter Crosthwaite
On Mon, Jul 6, 2015 at 4:52 AM, Paolo Bonzini wrote: > > > On 06/07/2015 13:42, Richard Henderson wrote: >> On 07/06/2015 09:43 AM, Paolo Bonzini wrote: >>> >>> >>> On 05/07/2015 23:08, Peter Crosthwaite wrote: There was a complicated subtractive arithmetic for determining the padding on

Re: [Qemu-devel] [PATCH] cpu_defs: Simplify CPUTLB padding logic

2015-07-06 Thread Paolo Bonzini
On 06/07/2015 13:42, Richard Henderson wrote: > On 07/06/2015 09:43 AM, Paolo Bonzini wrote: >> >> >> On 05/07/2015 23:08, Peter Crosthwaite wrote: >>> There was a complicated subtractive arithmetic for determining the >>> padding on the CPUTLBEntry structure. Simplify this with a union. >>> >>>

Re: [Qemu-devel] [PATCH] cpu_defs: Simplify CPUTLB padding logic

2015-07-06 Thread Richard Henderson
On 07/06/2015 09:43 AM, Paolo Bonzini wrote: On 05/07/2015 23:08, Peter Crosthwaite wrote: There was a complicated subtractive arithmetic for determining the padding on the CPUTLBEntry structure. Simplify this with a union. Signed-off-by: Peter Crosthwaite --- include/exec/cpu-defs.h | 23

Re: [Qemu-devel] [PATCH] cpu_defs: Simplify CPUTLB padding logic

2015-07-06 Thread Paolo Bonzini
On 06/07/2015 10:58, Peter Crosthwaite wrote: >> > Which compiler version started implementing anonymous structs? >> > > ISO C11 standardises it apparently. But various parts of the tree use > them now. target-arm/cpu.h, target-i386/kvm.c, > linux-user/syscall_defs.h and linux-headers/linux/kvm.h

Re: [Qemu-devel] [PATCH] cpu_defs: Simplify CPUTLB padding logic

2015-07-06 Thread Peter Crosthwaite
On Mon, Jul 6, 2015 at 1:43 AM, Paolo Bonzini wrote: > > > On 05/07/2015 23:08, Peter Crosthwaite wrote: >> There was a complicated subtractive arithmetic for determining the >> padding on the CPUTLBEntry structure. Simplify this with a union. >> >> Signed-off-by: Peter Crosthwaite >> --- >> inc

Re: [Qemu-devel] [PATCH] cpu_defs: Simplify CPUTLB padding logic

2015-07-06 Thread Paolo Bonzini
On 05/07/2015 23:08, Peter Crosthwaite wrote: > There was a complicated subtractive arithmetic for determining the > padding on the CPUTLBEntry structure. Simplify this with a union. > > Signed-off-by: Peter Crosthwaite > --- > include/exec/cpu-defs.h | 23 --- > 1 file cha

[Qemu-devel] [PATCH] cpu_defs: Simplify CPUTLB padding logic

2015-07-05 Thread Peter Crosthwaite
There was a complicated subtractive arithmetic for determining the padding on the CPUTLBEntry structure. Simplify this with a union. Signed-off-by: Peter Crosthwaite --- include/exec/cpu-defs.h | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/include/