Re: [Qemu-devel] [PATCH] cpu-exec: make TBs generated codes unlinked when -singlestep

2014-07-25 Thread Laurent Desnogues
Hello, On Fri, Jul 25, 2014 at 6:37 AM, Jincheng Miao wrote: > '-singlestep' option will make TB contains only one instruction, > so that the qemu_log could output trace log when CPU_LOG_EXEC sets, > and it could help developers to debug control flow. > > But currently, in cpu_exec(), it doesn't

Re: [Qemu-devel] [PATCH] cpu-exec: make TBs generated codes unlinked when -singlestep

2014-07-25 Thread Jincheng Miao
On 07/25/2014 03:45 PM, Peter Maydell wrote: On 25 July 2014 08:41, Richard Henderson wrote: On 07/24/2014 09:37 PM, Peter Maydell wrote: Huh? We already don't emit goto_tb if single-stepping, surely? (Well, I guess some of the backends might well be broken, but in that case they probably don

Re: [Qemu-devel] [PATCH] cpu-exec: make TBs generated codes unlinked when -singlestep

2014-07-25 Thread Peter Maydell
On 25 July 2014 08:41, Richard Henderson wrote: > On 07/24/2014 09:37 PM, Peter Maydell wrote: >> Huh? We already don't emit goto_tb if single-stepping, surely? >> (Well, I guess some of the backends might well be broken, but >> in that case they probably don't get the other bits of singlestep >>

Re: [Qemu-devel] [PATCH] cpu-exec: make TBs generated codes unlinked when -singlestep

2014-07-25 Thread Richard Henderson
On 07/24/2014 09:37 PM, Peter Maydell wrote: > Huh? We already don't emit goto_tb if single-stepping, surely? > (Well, I guess some of the backends might well be broken, but > in that case they probably don't get the other bits of singlestep > support right either...) Indeed. I noticed this a mon

Re: [Qemu-devel] [PATCH] cpu-exec: make TBs generated codes unlinked when -singlestep

2014-07-25 Thread Peter Maydell
On 25 July 2014 07:58, Richard Henderson wrote: > On 07/24/2014 06:37 PM, Jincheng Miao wrote: >> '-singlestep' option will make TB contains only one instruction, >> so that the qemu_log could output trace log when CPU_LOG_EXEC sets, >> and it could help developers to debug control flow. >> >> But

Re: [Qemu-devel] [PATCH] cpu-exec: make TBs generated codes unlinked when -singlestep

2014-07-25 Thread Richard Henderson
On 07/24/2014 06:37 PM, Jincheng Miao wrote: > '-singlestep' option will make TB contains only one instruction, > so that the qemu_log could output trace log when CPU_LOG_EXEC sets, > and it could help developers to debug control flow. > > But currently, in cpu_exec(), it doesn't check singlestep

[Qemu-devel] [PATCH] cpu-exec: make TBs generated codes unlinked when -singlestep

2014-07-24 Thread Jincheng Miao
'-singlestep' option will make TB contains only one instruction, so that the qemu_log could output trace log when CPU_LOG_EXEC sets, and it could help developers to debug control flow. But currently, in cpu_exec(), it doesn't check singlestep when tb_add_jump(), so the TB linked is executed silien