Re: [Qemu-devel] [PATCH] cpu-exec: Exit exclusive region on longjmp from step_atomic

2017-11-02 Thread Peter Maydell
On 2 November 2017 at 16:00, Alex Bennée wrote: > > Peter Maydell writes: > >> Commit ac03ee5331612e44be narrowed the scope of the exclusive >> region so it only covers when we're executing the TB, not when >> we're generating it. However it missed that there is more than >> one execution path ou

Re: [Qemu-devel] [PATCH] cpu-exec: Exit exclusive region on longjmp from step_atomic

2017-11-02 Thread Alex Bennée
Peter Maydell writes: > Commit ac03ee5331612e44be narrowed the scope of the exclusive > region so it only covers when we're executing the TB, not when > we're generating it. However it missed that there is more than > one execution path out of cpu_tb_exec -- if the atomic insn > causes an except

[Qemu-devel] [PATCH] cpu-exec: Exit exclusive region on longjmp from step_atomic

2017-11-02 Thread Peter Maydell
Commit ac03ee5331612e44be narrowed the scope of the exclusive region so it only covers when we're executing the TB, not when we're generating it. However it missed that there is more than one execution path out of cpu_tb_exec -- if the atomic insn causes an exception then the code will longjmp out,