Re: [Qemu-devel] [PATCH] cow: make padding in the header explicit

2014-09-05 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Thu, Sep 04, 2014 at 04:10:14PM +0200, Kevin Wolf wrote: >> Am 04.09.2014 um 15:51 hat Stefan Hajnoczi geschrieben: >> > On Thu, Sep 04, 2014 at 06:07:32AM -0600, Eric Blake wrote: >> > > On 09/04/2014 02:58 AM, Stefan Hajnoczi wrote: >> > > > On-disk structures shoul

Re: [Qemu-devel] [PATCH] cow: make padding in the header explicit

2014-09-05 Thread Kevin Wolf
Am 04.09.2014 um 17:43 hat Stefan Hajnoczi geschrieben: > On Thu, Sep 04, 2014 at 04:10:14PM +0200, Kevin Wolf wrote: > > Am 04.09.2014 um 15:51 hat Stefan Hajnoczi geschrieben: > > > On Thu, Sep 04, 2014 at 06:07:32AM -0600, Eric Blake wrote: > > > > On 09/04/2014 02:58 AM, Stefan Hajnoczi wrote:

Re: [Qemu-devel] [PATCH] cow: make padding in the header explicit

2014-09-04 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 04:10:14PM +0200, Kevin Wolf wrote: > Am 04.09.2014 um 15:51 hat Stefan Hajnoczi geschrieben: > > On Thu, Sep 04, 2014 at 06:07:32AM -0600, Eric Blake wrote: > > > On 09/04/2014 02:58 AM, Stefan Hajnoczi wrote: > > > > On-disk structures should be marked packed so the compil

Re: [Qemu-devel] [PATCH] cow: make padding in the header explicit

2014-09-04 Thread Kevin Wolf
Am 04.09.2014 um 15:51 hat Stefan Hajnoczi geschrieben: > On Thu, Sep 04, 2014 at 06:07:32AM -0600, Eric Blake wrote: > > On 09/04/2014 02:58 AM, Stefan Hajnoczi wrote: > > > On-disk structures should be marked packed so the compiler does not > > > insert padding for field alignment. Padding shoul

Re: [Qemu-devel] [PATCH] cow: make padding in the header explicit

2014-09-04 Thread Stefan Hajnoczi
On Thu, Sep 04, 2014 at 06:07:32AM -0600, Eric Blake wrote: > On 09/04/2014 02:58 AM, Stefan Hajnoczi wrote: > > On-disk structures should be marked packed so the compiler does not > > insert padding for field alignment. Padding should be explicit so > > on-disk layout is obvious and we don't rely

Re: [Qemu-devel] [PATCH] cow: make padding in the header explicit

2014-09-04 Thread shhuiw
At 2014-09-04 08:07:32, "Eric Blake" wrote: >On 09/04/2014 02:58 AM, Stefan Hajnoczi wrote: >> On-disk structures should be marked packed so the compiler does not >> insert padding for field alignment. Padding should be explicit so >> on-disk layout is obvious and we don't rely on the architect

Re: [Qemu-devel] [PATCH] cow: make padding in the header explicit

2014-09-04 Thread Eric Blake
On 09/04/2014 02:58 AM, Stefan Hajnoczi wrote: > On-disk structures should be marked packed so the compiler does not > insert padding for field alignment. Padding should be explicit so > on-disk layout is obvious and we don't rely on the architecture-specific > ABI for alignment rules. > > The pa

Re: [Qemu-devel] [PATCH] cow: make padding in the header explicit

2014-09-04 Thread Benoît Canet
The Thursday 04 Sep 2014 à 09:58:41 (+0100), Stefan Hajnoczi wrote : > On-disk structures should be marked packed so the compiler does not > insert padding for field alignment. Padding should be explicit so > on-disk layout is obvious and we don't rely on the architecture-specific > ABI for alignm

Re: [Qemu-devel] [PATCH] cow: make padding in the header explicit

2014-09-04 Thread Kevin Wolf
Am 04.09.2014 um 10:58 hat Stefan Hajnoczi geschrieben: > On-disk structures should be marked packed so the compiler does not > insert padding for field alignment. Padding should be explicit so > on-disk layout is obvious and we don't rely on the architecture-specific > ABI for alignment rules. >

[Qemu-devel] [PATCH] cow: make padding in the header explicit

2014-09-04 Thread Stefan Hajnoczi
On-disk structures should be marked packed so the compiler does not insert padding for field alignment. Padding should be explicit so on-disk layout is obvious and we don't rely on the architecture-specific ABI for alignment rules. The pahole(1) diff shows that the padding is now explicit and off