Re: [Qemu-devel] [PATCH] configure: ignore spice libraries on 32 bit.

2012-03-07 Thread Peter Maydell
On 7 March 2012 13:01, Alon Levy wrote: > > diff --git a/configure b/configure > index a5eb832..ecdfe9a 100755 > --- a/configure > +++ b/configure > @@ -2544,6 +2544,7 @@ EOF >   spice_cflags=$($pkg_config --cflags spice-protocol spice-server 2>/dev/null) >   spice_libs=$($pkg_config --libs spice-

Re: [Qemu-devel] [PATCH] configure: ignore spice libraries on 32 bit.

2012-03-07 Thread Alon Levy
On Wed, Mar 07, 2012 at 01:43:36PM +0100, Gerd Hoffmann wrote: > Hi, > > > git bisect blames commit 2e1a98c9c "qxl: introduce QXLCookie". > > Do we need a preprocessor guard so we don't try to use these > > if the host's spice headers don't support them? > > > (My host is Ubuntu Oneiric with li

Re: [Qemu-devel] [PATCH] configure: ignore spice libraries on 32 bit.

2012-03-07 Thread Gerd Hoffmann
Hi, > git bisect blames commit 2e1a98c9c "qxl: introduce QXLCookie". > Do we need a preprocessor guard so we don't try to use these > if the host's spice headers don't support them? > (My host is Ubuntu Oneiric with libspice-server-dev 0.8.2-2 > and spice-protocol-dev 0.8.0-0ubuntu1.) Hmm, spi

Re: [Qemu-devel] [PATCH] configure: ignore spice libraries on 32 bit.

2012-03-07 Thread Peter Maydell
On 7 March 2012 11:38, Gerd Hoffmann wrote: > But it still doesn't build indeed. > Looks like new warnings sneaked in ... Actually I get an outright compile error: CCui/spice-display.o ui/spice-display.c: In function ‘qemu_spice_add_memslot’: ui/spice-display.c:79:42: error: ‘QXL_IO_MEMSLO

Re: [Qemu-devel] [PATCH] configure: ignore spice libraries on 32 bit.

2012-03-07 Thread Peter Maydell
On 7 March 2012 11:38, Gerd Hoffmann wrote: > On 03/07/12 11:30, Peter Maydell wrote: >> Ping -- there seem to have been a couple of spice patch queue >> pulls since but did this warning fix patch get lost? > > commit f4a8a424fceb0f79bbd9f7ae4285c8a58eb5598e Yeah, I just spotted this, not sure wh

Re: [Qemu-devel] [PATCH] configure: ignore spice libraries on 32 bit.

2012-03-07 Thread Gerd Hoffmann
On 03/07/12 11:30, Peter Maydell wrote: > On 8 February 2012 15:22, Gerd Hoffmann wrote: >> On 02/08/12 01:17, Rusty Russell wrote: >>> As featured on: >>> https://bugs.launchpad.net/qemu-linaro/+bug/928432 >>> >>> Since we compile with -Werror, the presence of spice headers breaks >>> com

Re: [Qemu-devel] [PATCH] configure: ignore spice libraries on 32 bit.

2012-03-07 Thread Peter Maydell
On 8 February 2012 15:22, Gerd Hoffmann wrote: > On 02/08/12 01:17, Rusty Russell wrote: >> As featured on: >>         https://bugs.launchpad.net/qemu-linaro/+bug/928432 >> >> Since we compile with -Werror, the presence of spice headers breaks >> compile.  Yet except for x86-64, it doesn't compile

Re: [Qemu-devel] [PATCH] configure: ignore spice libraries on 32 bit.

2012-02-08 Thread Gerd Hoffmann
On 02/08/12 01:17, Rusty Russell wrote: > As featured on: > https://bugs.launchpad.net/qemu-linaro/+bug/928432 > > Since we compile with -Werror, the presence of spice headers breaks > compile. Yet except for x86-64, it doesn't compile, doesn't work, isn't > supported. See: http://spice-

[Qemu-devel] [PATCH] configure: ignore spice libraries on 32 bit.

2012-02-07 Thread Rusty Russell
As featured on: https://bugs.launchpad.net/qemu-linaro/+bug/928432 Since we compile with -Werror, the presence of spice headers breaks compile. Yet except for x86-64, it doesn't compile, doesn't work, isn't supported. See: http://spice-space.org/faq.html Signed-off-by: Rusty Russell --