Re: [Qemu-devel] [PATCH] configure: fix elf2dmp check

2018-11-27 Thread Roman Kagan
On Tue, Nov 27, 2018 at 07:50:54PM +0100, Paolo Bonzini wrote: > On 23/11/18 10:01, Roman Kagan wrote: > > elf2dmp is keyed on "$posix" = "yes", but "$posix" doesn't seem to be > > set anywhere. > > > > The original intent was presumably to skip building it on Windows, so > > check for "$mingw32"

Re: [Qemu-devel] [PATCH] configure: fix elf2dmp check

2018-11-27 Thread Paolo Bonzini
On 23/11/18 10:01, Roman Kagan wrote: > elf2dmp is keyed on "$posix" = "yes", but "$posix" doesn't seem to be > set anywhere. > > The original intent was presumably to skip building it on Windows, so > check for "$mingw32" = "no" instead. > > Signed-off-by: Roman Kagan > --- > configure | 2 +-

Re: [Qemu-devel] [PATCH] configure: fix elf2dmp check

2018-11-23 Thread Paolo Bonzini
On 23/11/18 10:01, Roman Kagan wrote: > elf2dmp is keyed on "$posix" = "yes", but "$posix" doesn't seem to be > set anywhere. > > The original intent was presumably to skip building it on Windows, so > check for "$mingw32" = "no" instead. > > Signed-off-by: Roman Kagan > --- > configure | 2 +-

Re: [Qemu-devel] [PATCH] configure: fix elf2dmp check

2018-11-23 Thread Philippe Mathieu-Daudé
On 23/11/18 10:01, Roman Kagan wrote: > elf2dmp is keyed on "$posix" = "yes", but "$posix" doesn't seem to be > set anywhere. > > The original intent was presumably to skip building it on Windows, so > check for "$mingw32" = "no" instead. > > Signed-off-by: Roman Kagan Reviewed-by: Philippe Mat

[Qemu-devel] [PATCH] configure: fix elf2dmp check

2018-11-23 Thread Roman Kagan
elf2dmp is keyed on "$posix" = "yes", but "$posix" doesn't seem to be set anywhere. The original intent was presumably to skip building it on Windows, so check for "$mingw32" = "no" instead. Signed-off-by: Roman Kagan --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g