Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-10 Thread Michael S. Tsirkin
On Thu, Jun 10, 2010 at 08:20:56AM +0100, Chris Webb wrote: > Markus Armbruster writes: > > > "Michael S. Tsirkin" writes: > > > > > Everyone ok with disabling vlans with no config option? > > > > Wrong question. You got to ask "anyone *not* ok with disabling vlans > > with no config option?"

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-10 Thread Chris Webb
Markus Armbruster writes: > "Michael S. Tsirkin" writes: > > > Everyone ok with disabling vlans with no config option? > > Wrong question. You got to ask "anyone *not* ok with disabling vlans > with no config option?" We do use socket devices in the form -net nic,model=e1000,vlan=X,mac=MM

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-09 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Mon, Jun 07, 2010 at 05:42:55PM +0100, Paul Brook wrote: >> > On Mon, Jun 07, 2010 at 05:16:30PM +0100, Paul Brook wrote: >> > > > With -netdev, there now seems to be little need to support vlans, >> > > > enabling them leads to user confusion and bad performance

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-08 Thread Anthony Liguori
On 06/08/2010 09:37 AM, Paul Brook wrote: I see three possible options to handle this. (1) Write a hub (or morph the current vlan code into this). Then you can do something like: qemu -netdev socket,id=p1 \ -netdev user,id=p2 \

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-08 Thread Paul Brook
> I see three possible options to handle this. > >(1) Write a hub (or morph the current vlan code into this). Then >you can do something like: > > qemu -netdev socket,id=p1 \ > -netdev user,id=p2 \ > -netdev dump,id=p3 \ >

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-08 Thread Gerd Hoffmann
On 06/08/10 15:02, Anthony Liguori wrote: On 06/08/2010 06:09 AM, Michael S. Tsirkin wrote: On Mon, Jun 07, 2010 at 03:40:57PM -0500, Anthony Liguori wrote: On 06/07/2010 02:21 PM, Michael S. Tsirkin wrote: So I see two ways to go forward: switch default value in my patch, or disable vlans unc

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-08 Thread Michael S. Tsirkin
On Tue, Jun 08, 2010 at 08:02:27AM -0500, Anthony Liguori wrote: > On 06/08/2010 06:09 AM, Michael S. Tsirkin wrote: >> On Mon, Jun 07, 2010 at 03:40:57PM -0500, Anthony Liguori wrote: >> >>> On 06/07/2010 02:21 PM, Michael S. Tsirkin wrote: >>> So I see two ways to go forward: switc

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-08 Thread Michael S. Tsirkin
On Tue, Jun 08, 2010 at 08:03:33AM -0500, Anthony Liguori wrote: > On 06/08/2010 07:13 AM, Michael S. Tsirkin wrote: >> On Mon, Jun 07, 2010 at 04:57:09PM -0500, Anthony Liguori wrote: >> >>> On 06/07/2010 04:37 PM, Anthony Liguori wrote: >>> On 06/07/2010 03:58 PM, Michael S. Tsirki

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-08 Thread Anthony Liguori
On 06/08/2010 07:13 AM, Michael S. Tsirkin wrote: On Mon, Jun 07, 2010 at 04:57:09PM -0500, Anthony Liguori wrote: On 06/07/2010 04:37 PM, Anthony Liguori wrote: On 06/07/2010 03:58 PM, Michael S. Tsirkin wrote: On Mon, Jun 07, 2010 at 03:40:57PM -0500, Anthony Liguori wrote:

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-08 Thread Anthony Liguori
On 06/08/2010 06:09 AM, Michael S. Tsirkin wrote: On Mon, Jun 07, 2010 at 03:40:57PM -0500, Anthony Liguori wrote: On 06/07/2010 02:21 PM, Michael S. Tsirkin wrote: So I see two ways to go forward: switch default value in my patch, or disable vlans unconditionally. The probl

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-08 Thread Michael S. Tsirkin
On Mon, Jun 07, 2010 at 05:16:30PM +0100, Paul Brook wrote: > > With -netdev, there now seems to be little need to support vlans, > > enabling them leads to user confusion and bad performance. > > Disable support for vlans by default, add config option to enable. > > No. If you want to remove vlan

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-08 Thread Michael S. Tsirkin
On Mon, Jun 07, 2010 at 04:57:09PM -0500, Anthony Liguori wrote: > On 06/07/2010 04:37 PM, Anthony Liguori wrote: >> On 06/07/2010 03:58 PM, Michael S. Tsirkin wrote: >>> On Mon, Jun 07, 2010 at 03:40:57PM -0500, Anthony Liguori wrote: On 06/07/2010 02:21 PM, Michael S. Tsirkin wrote: > So

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-08 Thread Michael S. Tsirkin
On Mon, Jun 07, 2010 at 03:40:57PM -0500, Anthony Liguori wrote: > On 06/07/2010 02:21 PM, Michael S. Tsirkin wrote: >> >> So I see two ways to go forward: switch default value in my patch, >> or disable vlans unconditionally. >> > > The problem with disabling vlans unconditionally is that you

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Anthony Liguori
On 06/07/2010 04:37 PM, Anthony Liguori wrote: On 06/07/2010 03:58 PM, Michael S. Tsirkin wrote: On Mon, Jun 07, 2010 at 03:40:57PM -0500, Anthony Liguori wrote: On 06/07/2010 02:21 PM, Michael S. Tsirkin wrote: So I see two ways to go forward: switch default value in my patch, or disable vlan

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Anthony Liguori
On 06/07/2010 03:58 PM, Michael S. Tsirkin wrote: On Mon, Jun 07, 2010 at 03:40:57PM -0500, Anthony Liguori wrote: On 06/07/2010 02:21 PM, Michael S. Tsirkin wrote: So I see two ways to go forward: switch default value in my patch, or disable vlans unconditionally. The probl

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Michael S. Tsirkin
On Mon, Jun 07, 2010 at 03:40:57PM -0500, Anthony Liguori wrote: > On 06/07/2010 02:21 PM, Michael S. Tsirkin wrote: >> >> So I see two ways to go forward: switch default value in my patch, >> or disable vlans unconditionally. >> > > The problem with disabling vlans unconditionally is that you

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Anthony Liguori
On 06/07/2010 02:21 PM, Michael S. Tsirkin wrote: So I see two ways to go forward: switch default value in my patch, or disable vlans unconditionally. The problem with disabling vlans unconditionally is that you break -net socket and -net dump. If we can come up with an alternative way

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Michael S. Tsirkin
On Mon, Jun 07, 2010 at 11:52:05AM -0500, Anthony Liguori wrote: > On 06/07/2010 11:42 AM, Paul Brook wrote: >>> On Mon, Jun 07, 2010 at 05:16:30PM +0100, Paul Brook wrote: >>> > With -netdev, there now seems to be little need to support vlans, > enabling them leads to user confusion

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Michael S. Tsirkin
On Mon, Jun 07, 2010 at 05:42:55PM +0100, Paul Brook wrote: > > On Mon, Jun 07, 2010 at 05:16:30PM +0100, Paul Brook wrote: > > > > With -netdev, there now seems to be little need to support vlans, > > > > enabling them leads to user confusion and bad performance. > > > > Disable support for vlans

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Anthony Liguori
On 06/07/2010 11:42 AM, Paul Brook wrote: On Mon, Jun 07, 2010 at 05:16:30PM +0100, Paul Brook wrote: With -netdev, there now seems to be little need to support vlans, enabling them leads to user confusion and bad performance. Disable support for vlans by default, add config option to enab

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Paul Brook
> On Mon, Jun 07, 2010 at 05:16:30PM +0100, Paul Brook wrote: > > > With -netdev, there now seems to be little need to support vlans, > > > enabling them leads to user confusion and bad performance. > > > Disable support for vlans by default, add config option to enable. > > > > No. If you want to

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Michael S. Tsirkin
On Mon, Jun 07, 2010 at 05:16:30PM +0100, Paul Brook wrote: > > With -netdev, there now seems to be little need to support vlans, > > enabling them leads to user confusion and bad performance. > > Disable support for vlans by default, add config option to enable. > > No. If you want to remove vlan

Re: [Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Paul Brook
> With -netdev, there now seems to be little need to support vlans, > enabling them leads to user confusion and bad performance. > Disable support for vlans by default, add config option to enable. No. If you want to remove vlans, then actually do that. As I've said before if you want a point-poin

[Qemu-devel] [PATCH] configure: add an option to disable vlans

2010-06-07 Thread Michael S. Tsirkin
With -netdev, there now seems to be little need to support vlans, enabling them leads to user confusion and bad performance. Disable support for vlans by default, add config option to enable. Signed-off-by: Michael S. Tsirkin --- configure | 12 net.c |7 +++ 2 files c