Re: [Qemu-devel] [PATCH] configure: Quote the configure args printed in config.log

2012-03-07 Thread Peter Maydell
On 7 March 2012 17:14, Avi Kivity wrote: > This still breaks if an argument has a single quote.  bash's printf's %q > deals with this correctly, but not sure how portable it is. True, but we've lived with it for the code that writes to config-host.mak since 2008 (commit fd69fe2b)... -- PMM

Re: [Qemu-devel] [PATCH] configure: Quote the configure args printed in config.log

2012-03-07 Thread Eric Blake
On 03/07/2012 10:08 AM, Peter Maydell wrote: > If you look at the whole change, rather than just the > fragment Stefan quoted to comment on: > > # Print a helpful header at the top of config.log > echo "# QEMU configure log $(date)" >> config.log > -echo "# produced by $0 $*" >> config.log > +pr

Re: [Qemu-devel] [PATCH] configure: Quote the configure args printed in config.log

2012-03-07 Thread Avi Kivity
On 03/07/2012 02:16 PM, Peter Maydell wrote: > Use the same mechanism we use for printing the configure command > line to config-host.mak to print it to config.log. This fixes a > bug where the config.log version didn't quote arguments with spaces. > > # Print a helpful header at the top of conf

Re: [Qemu-devel] [PATCH] configure: Quote the configure args printed in config.log

2012-03-07 Thread Peter Maydell
On 7 March 2012 12:40, Stefan Hajnoczi wrote: >> +printf "# Configured with:" >> config.log >> +printf " '%s'" "$0" "$@" >> config.log > > You use an interesting feature of printf(1)- it applies the (short) > format string as long as there are arguments.  I checked that this is > in the specificat

Re: [Qemu-devel] [PATCH] configure: Quote the configure args printed in config.log

2012-03-07 Thread Peter Maydell
On 7 March 2012 17:06, Eric Blake wrote: >>>  # Print a helpful header at the top of config.log >>>  echo "# QEMU configure log $(date)" >> config.log >>> -echo "# produced by $0 $*" >> config.log > > This left a trailing newline, > >>> +printf "# Configured with:" >> config.log >>> +printf " '%s'

Re: [Qemu-devel] [PATCH] configure: Quote the configure args printed in config.log

2012-03-07 Thread Eric Blake
On 03/07/2012 05:40 AM, Stefan Hajnoczi wrote: > On Wed, Mar 7, 2012 at 12:16 PM, Peter Maydell > wrote: >> Use the same mechanism we use for printing the configure command >> line to config-host.mak to print it to config.log. This fixes a >> bug where the config.log version didn't quote argument

Re: [Qemu-devel] [PATCH] configure: Quote the configure args printed in config.log

2012-03-07 Thread Stefan Hajnoczi
On Wed, Mar 7, 2012 at 12:16 PM, Peter Maydell wrote: > Use the same mechanism we use for printing the configure command > line to config-host.mak to print it to config.log. This fixes a > bug where the config.log version didn't quote arguments with spaces. > > Signed-off-by: Peter Maydell > ---

[Qemu-devel] [PATCH] configure: Quote the configure args printed in config.log

2012-03-07 Thread Peter Maydell
Use the same mechanism we use for printing the configure command line to config-host.mak to print it to config.log. This fixes a bug where the config.log version didn't quote arguments with spaces. Signed-off-by: Peter Maydell --- If I'd noticed when I was adding the banner to config.log that we