Re: [Qemu-devel] [PATCH] colo-compare: fix find_and_check_chardev()

2016-10-20 Thread Jason Wang
On 2016年10月20日 12:53, Hailiang Zhang wrote: On 2016/10/20 11:53, Jason Wang wrote: On 2016年10月10日 11:49, Zhang Chen wrote: On 10/10/2016 11:13 AM, Hailiang Zhang wrote: Hi, On 2016/10/10 10:52, Zhang Chen wrote: On 09/30/2016 12:06 PM, zhanghailiang wrote: find_and_check_chardev() u

Re: [Qemu-devel] [PATCH] colo-compare: fix find_and_check_chardev()

2016-10-19 Thread Hailiang Zhang
On 2016/10/20 11:53, Jason Wang wrote: On 2016年10月10日 11:49, Zhang Chen wrote: On 10/10/2016 11:13 AM, Hailiang Zhang wrote: Hi, On 2016/10/10 10:52, Zhang Chen wrote: On 09/30/2016 12:06 PM, zhanghailiang wrote: find_and_check_chardev() uses 'opts' member of CharDriverState to check i

Re: [Qemu-devel] [PATCH] colo-compare: fix find_and_check_chardev()

2016-10-19 Thread Hailiang Zhang
Hi Jason, On 2016/10/20 10:12, Jason Wang wrote: On 2016年09月30日 12:06, zhanghailiang wrote: find_and_check_chardev() uses 'opts' member of CharDriverState to check if the chardev is 'socket' chardev or not, which the opts will be NULL if We add the chardev by qmp 'chardev-add' command. All t

Re: [Qemu-devel] [PATCH] colo-compare: fix find_and_check_chardev()

2016-10-19 Thread Jason Wang
On 2016年10月10日 11:49, Zhang Chen wrote: On 10/10/2016 11:13 AM, Hailiang Zhang wrote: Hi, On 2016/10/10 10:52, Zhang Chen wrote: On 09/30/2016 12:06 PM, zhanghailiang wrote: find_and_check_chardev() uses 'opts' member of CharDriverState to check if the chardev is 'socket' chardev or not

Re: [Qemu-devel] [PATCH] colo-compare: fix find_and_check_chardev()

2016-10-19 Thread Jason Wang
On 2016年09月30日 12:06, zhanghailiang wrote: find_and_check_chardev() uses 'opts' member of CharDriverState to check if the chardev is 'socket' chardev or not, which the opts will be NULL if We add the chardev by qmp 'chardev-add' command. All the related info can be found in 'filename' member o

Re: [Qemu-devel] [PATCH] colo-compare: fix find_and_check_chardev()

2016-10-09 Thread Hailiang Zhang
On 2016/10/10 11:49, Zhang Chen wrote: On 10/10/2016 11:13 AM, Hailiang Zhang wrote: Hi, On 2016/10/10 10:52, Zhang Chen wrote: On 09/30/2016 12:06 PM, zhanghailiang wrote: find_and_check_chardev() uses 'opts' member of CharDriverState to check if the chardev is 'socket' chardev or not, w

Re: [Qemu-devel] [PATCH] colo-compare: fix find_and_check_chardev()

2016-10-09 Thread Hailiang Zhang
Hi, On 2016/10/10 10:52, Zhang Chen wrote: On 09/30/2016 12:06 PM, zhanghailiang wrote: find_and_check_chardev() uses 'opts' member of CharDriverState to check if the chardev is 'socket' chardev or not, which the opts will be NULL if We add the chardev by qmp 'chardev-add' command. All the r

Re: [Qemu-devel] [PATCH] colo-compare: fix find_and_check_chardev()

2016-10-09 Thread Zhang Chen
On 10/10/2016 11:13 AM, Hailiang Zhang wrote: Hi, On 2016/10/10 10:52, Zhang Chen wrote: On 09/30/2016 12:06 PM, zhanghailiang wrote: find_and_check_chardev() uses 'opts' member of CharDriverState to check if the chardev is 'socket' chardev or not, which the opts will be NULL if We add the

Re: [Qemu-devel] [PATCH] colo-compare: fix find_and_check_chardev()

2016-10-09 Thread Zhang Chen
On 09/30/2016 12:06 PM, zhanghailiang wrote: find_and_check_chardev() uses 'opts' member of CharDriverState to check if the chardev is 'socket' chardev or not, which the opts will be NULL if We add the chardev by qmp 'chardev-add' command. All the related info can be found in 'filename' member

[Qemu-devel] [PATCH] colo-compare: fix find_and_check_chardev()

2016-09-29 Thread zhanghailiang
find_and_check_chardev() uses 'opts' member of CharDriverState to check if the chardev is 'socket' chardev or not, which the opts will be NULL if We add the chardev by qmp 'chardev-add' command. All the related info can be found in 'filename' member of CharDriverState, For tcp socket device, it wi