Re: [Qemu-devel] [PATCH] cocoa: stop using MOUSE_EVENT_*

2017-01-26 Thread Peter Maydell
On 17 January 2017 at 15:20, Gerd Hoffmann wrote: > On Di, 2017-01-17 at 10:44 +, Peter Maydell wrote: >> On 17 January 2017 at 08:20, Gerd Hoffmann wrote: >> > On Mo, 2017-01-16 at 18:35 +, Peter Maydell wrote: >> >> On 11 January 2017 at 10:58, Gerd Hoffmann wrote: >> >> > No need to g

Re: [Qemu-devel] [PATCH] cocoa: stop using MOUSE_EVENT_*

2017-01-17 Thread Gerd Hoffmann
On Di, 2017-01-17 at 10:44 +, Peter Maydell wrote: > On 17 January 2017 at 08:20, Gerd Hoffmann wrote: > > On Mo, 2017-01-16 at 18:35 +, Peter Maydell wrote: > >> On 11 January 2017 at 10:58, Gerd Hoffmann wrote: > >> > No need to go the indirect route with a bitfield and mapping the bits

Re: [Qemu-devel] [PATCH] cocoa: stop using MOUSE_EVENT_*

2017-01-17 Thread Peter Maydell
On 17 January 2017 at 08:20, Gerd Hoffmann wrote: > On Mo, 2017-01-16 at 18:35 +, Peter Maydell wrote: >> On 11 January 2017 at 10:58, Gerd Hoffmann wrote: >> > No need to go the indirect route with a bitfield and mapping the bits to >> > INPUT_BUTTON_*. We can use a bool array and INPUT_BUT

Re: [Qemu-devel] [PATCH] cocoa: stop using MOUSE_EVENT_*

2017-01-17 Thread Gerd Hoffmann
On Mo, 2017-01-16 at 18:35 +, Peter Maydell wrote: > On 11 January 2017 at 10:58, Gerd Hoffmann wrote: > > No need to go the indirect route with a bitfield and mapping the bits to > > INPUT_BUTTON_*. We can use a bool array and INPUT_BUTTON_* directly > > instead. > > > > Untested, not even c

Re: [Qemu-devel] [PATCH] cocoa: stop using MOUSE_EVENT_*

2017-01-16 Thread Peter Maydell
On 11 January 2017 at 10:58, Gerd Hoffmann wrote: > No need to go the indirect route with a bitfield and mapping the bits to > INPUT_BUTTON_*. We can use a bool array and INPUT_BUTTON_* directly > instead. > > Untested, not even compiled, due to lack of a osx^Wmacos machine. > Test results are ve

[Qemu-devel] [PATCH] cocoa: stop using MOUSE_EVENT_*

2017-01-11 Thread Gerd Hoffmann
No need to go the indirect route with a bitfield and mapping the bits to INPUT_BUTTON_*. We can use a bool array and INPUT_BUTTON_* directly instead. Untested, not even compiled, due to lack of a osx^Wmacos machine. Test results are very welcome. Signed-off-by: Gerd Hoffmann --- ui/cocoa.m | 4